Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-27 Thread Chris Ball
Hi Doug, On Fri, Jun 07 2013, Doug Anderson wrote: > It is possible to specify a regulator that should be turned on when > dw_mmc is probed. At the moment dw_mmc will fail to use the regulator > properly if the regulator probes after dw_mmc. Fix this problem by > honoring EPROBE_DEFER. > > At th

Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-27 Thread Chris Ball
Hi Doug, On Fri, Jun 07 2013, Doug Anderson wrote: > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index bc3a1bc..ab5642d 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1895,7 +1895,7 @@ static int dw_mci_init_slot(struct dw_mci *host, > un

Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-27 Thread Doug Anderson
Chris, On Thu, Jun 27, 2013 at 9:44 AM, Chris Ball wrote: > This hunk breaks the build for me, because err_setup_bus and ret are > used in the error path of the call to mmc_add_host() in this function. > > I'll push a version that leaves those in. Let me know if you think > something strange is

Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 10:28:29 Doug Anderson wrote: > It is possible to specify a regulator that should be turned on when > dw_mmc is probed. At the moment dw_mmc will fail to use the regulator > properly if the regulator probes after dw_mmc. Fix this problem by > honoring EPROBE_DEFER. > >

Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER

2013-06-07 Thread Doug Anderson
Tomasz, On Fri, Jun 7, 2013 at 10:42 AM, Tomasz Figa wrote: > A question just out of curiousity: Is it really correct to have one vmmc > regulator for the whole device, instead of one regulator per slot? > > This might be something obvious, but I don't know any details about > dw_mmc, so sorry if