Re: [PATCH v3 0/4] DT clock bindings

2012-07-02 Thread Rob Herring
Mike, On 07/02/2012 08:30 PM, Turquette, Mike wrote: > On Wed, Jun 27, 2012 at 5:54 AM, Rob Herring wrote: >> On 06/21/2012 12:54 PM, Mike Turquette wrote: >>> On 20120621-10:00, Rob Herring wrote: On 06/21/2012 02:27 AM, Chris Ball wrote: > > 2) Use alloc_bootmem() instead of kzallo

Re: [PATCH v3 0/4] DT clock bindings

2012-07-02 Thread Turquette, Mike
On Wed, Jun 27, 2012 at 5:54 AM, Rob Herring wrote: > On 06/21/2012 12:54 PM, Mike Turquette wrote: >> On 20120621-10:00, Rob Herring wrote: >>> On 06/21/2012 02:27 AM, Chris Ball wrote: 2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(),    because we need to set

Re: [PATCH v3 0/4] DT clock bindings

2012-06-27 Thread Rob Herring
On 06/21/2012 12:54 PM, Mike Turquette wrote: > On 20120621-10:00, Rob Herring wrote: >> On 06/21/2012 02:27 AM, Chris Ball wrote: >>> >>> 2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(), >>>because we need to set up clocks during .init_early on ARM (which >>>happens pr

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Mike Turquette
On 20120621-10:00, Rob Herring wrote: > On 06/21/2012 02:27 AM, Chris Ball wrote: > > > > 2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(), > >because we need to set up clocks during .init_early on ARM (which > >happens pre-slab) so that they are available for platform

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Rob Herring
Chris, On 06/21/2012 02:27 AM, Chris Ball wrote: > Hi Rob, > > On Tue, Jun 12 2012, Rob Herring wrote: >> This series defines clock bindings for Device-Tree and adds kernel >> support using the common clock infrastructure. The last patch enables >> DT clock suppo

Re: [PATCH v3 0/4] DT clock bindings

2012-06-21 Thread Chris Ball
Hi Rob, On Tue, Jun 12 2012, Rob Herring wrote: > This series defines clock bindings for Device-Tree and adds kernel > support using the common clock infrastructure. The last patch enables > DT clock support for the Calxeda Highbank platform. > > I'm posting this again to so

Re: [PATCH v3 0/4] DT clock bindings

2012-06-15 Thread Rob Herring
+++ > arch/arm/boot/dts/imx6q.dtsi | 27 +++++- > arch/arm/mach-imx/clk-imx6q.c | 31 ++- > 3 files changed, 101 insertions(+), 15 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clk/clk-im

Re: [PATCH v3 0/4] DT clock bindings

2012-06-15 Thread Stephen Warren
On 06/15/2012 02:39 AM, Shawn Guo wrote: > On Tue, Jun 12, 2012 at 09:41:47AM -0500, Rob Herring wrote: >> I'm posting this again to solicit further review. There has been some >> discussion[1], but no definite path forward. This series is not changed >> from the last post other than rebasing to v3

Re: [PATCH v3 0/4] DT clock bindings

2012-06-15 Thread Shawn Guo
++- arch/arm/mach-imx/clk-imx6q.c | 31 ++- 3 files changed, 101 insertions(+), 15 deletions(-) create mode 100644 Documentation/devicetree/bindings/clk/clk-imx6q.txt diff --git a/Documentation/devicetree/bindings/clk/clk-imx6q.txt b/Documentation/devicetree/binding

Re: [PATCH v3 0/4] DT clock bindings

2012-06-14 Thread Shawn Guo
On Tue, Jun 12, 2012 at 11:23:18AM -0500, Rob Herring wrote: > Right. This is why I have reposted and copied those whom commented on my > pull request. I think at least some of Saravana's concerns boiled down > to not requiring using DT clock bindings and not requiring driver > c

Re: [PATCH v3 0/4] DT clock bindings

2012-06-13 Thread Rob Herring
Peter, On 06/13/2012 10:26 AM, Peter De Schrijver wrote: > On Tue, Jun 12, 2012 at 04:41:47PM +0200, Rob Herring wrote: >> From: Rob Herring >> >> This series defines clock bindings for Device-Tree and adds kernel >> support using the common clock infrastructure. T

Re: [PATCH v3 0/4] DT clock bindings

2012-06-13 Thread Peter De Schrijver
On Tue, Jun 12, 2012 at 04:41:47PM +0200, Rob Herring wrote: > From: Rob Herring > > This series defines clock bindings for Device-Tree and adds kernel > support using the common clock infrastructure. The last patch enables > DT clock support for the Calxeda Highbank platform. &

Re: [PATCH v3 0/4] DT clock bindings

2012-06-12 Thread Rob Herring
On 06/12/2012 10:47 AM, Mike Turquette wrote: > On 20120612-09:41, Rob Herring wrote: >> From: Rob Herring >> >> This series defines clock bindings for Device-Tree and adds kernel >> support using the common clock infrastructure. The last patch enables >> DT clock

Re: [PATCH v3 0/4] DT clock bindings

2012-06-12 Thread Mike Turquette
On 20120612-09:41, Rob Herring wrote: > From: Rob Herring > > This series defines clock bindings for Device-Tree and adds kernel > support using the common clock infrastructure. The last patch enables > DT clock support for the Calxeda Highbank platform. > > I'm pos

[PATCH v3 0/4] DT clock bindings

2012-06-12 Thread Rob Herring
From: Rob Herring This series defines clock bindings for Device-Tree and adds kernel support using the common clock infrastructure. The last patch enables DT clock support for the Calxeda Highbank platform. I'm posting this again to solicit further review. There has been some discussion[1]

Re: [U-Boot] [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-03-06 Thread Simon Glass
Hi Tom, On Mon, Mar 5, 2012 at 12:46 PM, Tom Rini wrote: > On Tue, Feb 28, 2012 at 10:41:15AM -0800, Stephen Warren wrote: >> Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: >> > On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren >> > wrote: >> > > Simon Glass wrote at Tuesday, February

Re: [U-Boot] [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-03-06 Thread Tom Rini
On Tue, Feb 28, 2012 at 10:41:15AM -0800, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: > > On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren wrote: > > > Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: > > > ... > > >> I am going to add your binding, l

Re: [U-Boot] [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-03-03 Thread Simon Glass
Hi Albert, On Tue, Feb 28, 2012 at 2:16 PM, Albert ARIBAUD wrote: > Le 28/02/2012 19:46, Simon Glass a écrit : > >> Hi Stephen, >> >> On Tue, Feb 28, 2012 at 10:41 AM, Stephen Warren >>  wrote: >>> >>> Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: On Tue, Feb 28, 2012 at 10:

Re: [U-Boot] [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Albert ARIBAUD
Le 28/02/2012 19:46, Simon Glass a écrit : Hi Stephen, On Tue, Feb 28, 2012 at 10:41 AM, Stephen Warren wrote: Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren wrote: Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: ... I a

Re: [PATCH v7 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
Hi Stephen, On Tue, Feb 28, 2012 at 10:47 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM: >> Add the definition of the oscillator clock frequency and the 32KHz clock. >> The latter is provided by a PMIC on I2C which we don't actually use at >> present, but we

RE: [PATCH v7 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Stephen Warren
Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM: > Add the definition of the oscillator clock frequency and the 32KHz clock. > The latter is provided by a PMIC on I2C which we don't actually use at > present, but we expect this definition to be used in the kernel and want > to keep our .dt

Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
Hi Stephen, On Tue, Feb 28, 2012 at 10:41 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: >> On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren wrote: >> > Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: >> > ... >> >> I am going to add your binding,

RE: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Stephen Warren
Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: > On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren wrote: > > Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: > > ... > >> I am going to add your binding, less the #clock-cells which U-Boot > >> currently can't support because it

Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
Hi Stephen, On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: > ... >> I am going to add your binding, less the #clock-cells which U-Boot >> currently can't support because it conflicts with the C preprocessor >> (at some point I m

RE: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Stephen Warren
Simon Glass wrote at Tuesday, February 28, 2012 10:38 AM: ... > I am going to add your binding, less the #clock-cells which U-Boot > currently can't support because it conflicts with the C preprocessor > (at some point I may look at a patch to use sed or some other means of > avoiding this). Out o

[PATCH v7 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
- Add new patch to bring in clock bindings to seaboard Changes in v7: - Add in i2c pmic information and 32KHz clock board/nvidia/dts/tegra2-seaboard.dts | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/board/nvidia/dts/tegra2-seaboard.dts b/

Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
Hi Stephen, On Tue, Feb 28, 2012 at 9:32 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 10:21 AM: >> On Mon, Feb 27, 2012 at 3:29 PM, Stephen Warren wrote: >> > On 02/27/2012 01:52 PM, Simon Glass wrote: >> >> Add the definition of the oscillator clock frequency. >>

RE: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Stephen Warren
Simon Glass wrote at Tuesday, February 28, 2012 10:21 AM: > On Mon, Feb 27, 2012 at 3:29 PM, Stephen Warren wrote: > > On 02/27/2012 01:52 PM, Simon Glass wrote: > >> Add the definition of the oscillator clock frequency. > > > >> diff --git a/board/nvidia/dts/tegra2-seaboard.dts > >> b/board/nvid

Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-28 Thread Simon Glass
Hi Stephen, On Mon, Feb 27, 2012 at 3:29 PM, Stephen Warren wrote: > On 02/27/2012 01:52 PM, Simon Glass wrote: >> Add the definition of the oscillator clock frequency. > >> diff --git a/board/nvidia/dts/tegra2-seaboard.dts >> b/board/nvidia/dts/tegra2-seaboard.dts > >> +     clock@60006000 { >>

Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-27 Thread Stephen Warren
On 02/27/2012 01:52 PM, Simon Glass wrote: > Add the definition of the oscillator clock frequency. > diff --git a/board/nvidia/dts/tegra2-seaboard.dts > b/board/nvidia/dts/tegra2-seaboard.dts > + clock@60006000 { > + clocks = <&osc>; > + }; The CAR takes two clock inputs; on

[PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-02-27 Thread Simon Glass
Add the definition of the oscillator clock frequency. Signed-off-by: Simon Glass --- Changes in v6: - Add new patch to bring in clock bindings to seaboard board/nvidia/dts/tegra2-seaboard.dts | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/board/nvidia/dts

[PATCH v6 10/20] tegra: fdt: Add clock bindings

2012-02-27 Thread Simon Glass
This adds a basic binding for the oscillator and peripheral clocks. The second cell is the clock number, defined as the bit number within the clock enable register if the peripheral clock. This uses the RFC clock bindings from Grant Likely so may change later: https://lkml.org/lkml/2011/12/12

[PATCH v5 09/18] tegra: fdt: Add clock bindings

2012-01-24 Thread Simon Glass
This adds a basic binding for the oscillator and peripheral clocks. The second cell is the clock number, defined as the bit number within the clock enable register if the peripheral clock. This uses the RFC clock bindings from Grant Likely so may change later: https://lkml.org/lkml/2011/12/12

[PATCH v4 11/20] tegra: fdt: Add clock bindings

2012-01-11 Thread Simon Glass
This adds a basic binding for the oscillator and peripheral clocks. The second cell is the clock number, defined as the bit number within the clock enable register if the peripheral clock. This uses the RFC clock bindings from Grant Likely so may change later: https://lkml.org/lkml/2011/12/12

Re: Initial DT clock bindings

2012-01-11 Thread Simon Glass
Hi Grant, On Mon, Dec 12, 2011 at 2:52 PM, Rob Herring wrote: > On 12/12/2011 04:00 PM, Grant Likely wrote: >> Hi everyone, >> >> Here's my second posting of initial device tree bindings for clocks.  I'm >> a lot happier with how this is looking now, and Versatile is pretty much >> entirely conve

Re: Initial DT clock bindings

2011-12-12 Thread Rob Herring
On 12/12/2011 04:00 PM, Grant Likely wrote: > Hi everyone, > > Here's my second posting of initial device tree bindings for clocks. I'm > a lot happier with how this is looking now, and Versatile is pretty much > entirely converted. In fact, the realview, integrator and vexpress platforms > are

Initial DT clock bindings

2011-12-12 Thread Grant Likely
Hi everyone, Here's my second posting of initial device tree bindings for clocks. I'm a lot happier with how this is looking now, and Versatile is pretty much entirely converted. In fact, the realview, integrator and vexpress platforms are pretty close now too. Just for fun I went and converted

[RFC 0/8] Initial DT clock bindings

2011-11-08 Thread Grant Likely
Hey all, here is an initial implementation of the DT clock bindings with the versatile platform modified to use them. I'm fairly happy with how this has turned out, although I'll probably roll the clock lookup stuff directly into drivers/clk/clkdev.c which will simplify things a bit. P

Re: clock bindings

2011-04-04 Thread Grant Likely
On Fri, Apr 01, 2011 at 02:43:04PM +0800, Shawn Guo wrote: > On Thu, Mar 31, 2011 at 04:45:47PM -0600, Grant Likely wrote: > > On Wed, Feb 02, 2011 at 10:47:40AM -0600, Rob Herring wrote: > > > I've started looking at the DT clock bindings in more depth. To what > >

Re: clock bindings

2011-03-31 Thread Shawn Guo
On Thu, Mar 31, 2011 at 04:45:47PM -0600, Grant Likely wrote: > On Wed, Feb 02, 2011 at 10:47:40AM -0600, Rob Herring wrote: > > I've started looking at the DT clock bindings in more depth. To what > > level should the clock tree be defined in the DT? Should it be a > >

Re: clock bindings

2011-03-31 Thread Grant Likely
On Wed, Feb 02, 2011 at 10:47:40AM -0600, Rob Herring wrote: > I've started looking at the DT clock bindings in more depth. To what > level should the clock tree be defined in the DT? Should it be a > one-to-one correlation of current struct clk nodes to node in DT > where each

clock bindings

2011-02-02 Thread Rob Herring
I've started looking at the DT clock bindings in more depth. To what level should the clock tree be defined in the DT? Should it be a one-to-one correlation of current struct clk nodes to node in DT where each node is a single input and output? Or only define a single (or few) node wit