Re: [PATCH] udisks: fix a bug of unquoted/unescaped label string

2010-10-14 Thread Martin Pitt
Hello Jiro, Jiro SEKIBA [2010-10-15 13:44 +0900]: > This patch quotes/escapes label string for nilfs-tune. Thanks, applied. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___

[PATCH] udisks: escape backslash for label string

2010-10-14 Thread Jiro SEKIBA
validate_and_escape_label will only escapes '"'. However, string '\"' will be escaped to '\\"' which leads unmatched double quote for shell string in result. This adds escaping '\' in validate_and_escape_label to avoid the problem. Signed-off-by: Jiro SEKIBA --- src/helpers/job-shared.h |5

[PATCH] udisks: fix a bug of unquoted/unescaped label string

2010-10-14 Thread Jiro SEKIBA
This patch quotes/escapes label string for nilfs-tune. Signed-off-by: Jiro SEKIBA --- src/helpers/job-change-filesystem-label.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/helpers/job-change-filesystem-label.c b/src/helpers/job-change-filesystem-label.c inde

Re: [PATCH] udisks: add nilfs2 label rename

2010-10-14 Thread Jiro SEKIBA
At Thu, 14 Oct 2010 06:17:30 -0700, Dan Nicholson wrote: > > On Wed, Oct 13, 2010 at 10:56 PM, Jiro SEKIBA wrote: > > Hi, > > > > This is a patch to support renaming label of nilfs2 partition. > > Renaming is done by nilfs2-tune, which is in nilfs2-util > 2.0.20. > > > > This patch enables the la

Re: [PATCH] udisks: add nilfs2 label rename

2010-10-14 Thread Dan Nicholson
On Wed, Oct 13, 2010 at 10:56 PM, Jiro SEKIBA wrote: > Hi, > > This is a patch to support renaming label of nilfs2 partition. > Renaming is done by nilfs2-tune, which is in nilfs2-util > 2.0.20. > > This patch enables the label test excluded for lacking utility. > > Signed-off-by: Jiro SEKIBA > -

Re: [PATCH] udisks: add nilfs2 label rename

2010-10-14 Thread Martin Pitt
Hello Jiro, Jiro SEKIBA [2010-10-14 14:56 +0900]: > This is a patch to support renaming label of nilfs2 partition. > Renaming is done by nilfs2-tune, which is in nilfs2-util > 2.0.20. This looks fine, thanks! Pushed. Martin -- Martin Pitt| http://www.piware.de Ubuntu Dev