Re: [upower PATCH 1/2] simplify 'on-battery' detection to avoid depending on unreliable battery state

2010-10-21 Thread Richard Hughes
On 12 October 2010 13:42, Michal Schmidt wrote: > A fix could be to remove all the guesswork in step 3. But the heuristics may > be > useful in other cases. If you're discharging on a UPS, you're also "on-battery" -- no? Maybe we can just ignore batteries in unknown state in up_daemon_get_on_ba

Re: [upower PATCH 2/2] remove the UP_DEVICE_SUPPLY_CHARGED_THRESHOLD heuristic

2010-10-21 Thread Richard Hughes
On 12 October 2010 13:42, Michal Schmidt wrote: > I see no reason to delay the reporting of discharging of the battery. > Let's remove this heuristic. IIRC, this functionality was required for batteries that just stopped reporting the state after the energy level stopped going up. It's probably

[upower PATCH 2/2] remove the UP_DEVICE_SUPPLY_CHARGED_THRESHOLD heuristic

2010-10-21 Thread Michal Schmidt
When a full battery starts to discharge, but reports its status as 'Unknown', it takes a few minutes before g-p-m notices any change. upowerd guesses the battery is fully charged as long as it has over 90% charge. I see no reason to delay the reporting of discharging of the battery. Let's remove t

[upower PATCH 1/2] simplify 'on-battery' detection to avoid depending on unreliable battery state

2010-10-21 Thread Michal Schmidt
When calculating the global 'on-battery' state upowerd queries the state of AC supplies as well as the state of all batteries. On my Fujitsu Esprimo Mobile M9400 laptop the AC information is always correct, but the battery is not giving useful status (from looking at ACPI DSDT, I concluded that it

Re: [PATCH] udisks: Avoid deprecated polkit_authority_get() function

2010-10-21 Thread Martin Pitt
Hello Marti, Marti Raudsepp [2010-10-20 21:33 +0300]: > Apparently the polkit_authority_get() function was deprecated in some > recent PolicyKit release: In particular, this was done in commit 322513b0d4ee1f0c291495712a7f637132bde149, i. e. in polkit-1 0.97. I can't currently test this (Debian/Ub

Re: [PATCH] GCC 4.5 warning case value ‘4294967295’ not in enumerated type ‘PartitionScheme’

2010-10-21 Thread Martin Pitt
Hello Marti, Marti Raudsepp [2010-10-20 19:27 +0300]: > Since nobody responded the last time Ah, sorry about that. Must have gotten lost in the stack. > I am still hitting this problem when building latest git version with > GCC 4.5.1. Normally this would be a warning, but since udisks builds >