Re: K750 fixes in hidpp-rework branch

2013-08-28 Thread Julien Danjou
On Wed, Aug 28 2013, Peter Wu wrote: Hi Peter, > I do not own the K750, so I haven't tested it yet. Thanks for testing btw! It > turns out to be a signedness issue *sigh*. The new code (amended) has been > pushed, please git pull -f! Indeed, that fixes everything: Device: /org/freedesktop/UPo

Re: K750 fixes in hidpp-rework branch

2013-08-28 Thread Peter Wu
On Wednesday 28 August 2013 23:37:12 Julien Danjou wrote: > On Wed, Aug 28 2013, Peter Wu wrote: > > Makes sense, please test the updated code in > > https://git.lekensteyn.nl/upower/?h=hidpp-rework . There is still a FIXME, > > currently I assume that the device is charging whenever there is light

Re: K750 fixes in hidpp-rework branch

2013-08-28 Thread Julien Danjou
On Wed, Aug 28 2013, Peter Wu wrote: > Makes sense, please test the updated code in > https://git.lekensteyn.nl/upower/?h=hidpp-rework . There is still a FIXME, > currently I assume that the device is charging whenever there is light, but > this is very likely wrong. Obviously it's wrong :), b

K750 fixes in hidpp-rework branch (was: Re: UPower 0.9.21)

2013-08-28 Thread Peter Wu
> > A notification should appear within a second of the request. > > 17:33:40.645 Send report_id=10 short device=02 DEV2 > type=09 params=0F 01 01 00 17:33:40.676 > Recv report_id=11 long device=02 DEV2 > type=09 params=0F 01 01 00 00

Re: UPower 0.9.21

2013-08-28 Thread Julien Danjou
On Wed, Aug 28 2013, Peter Wu wrote: > I made a mistake again, I took the "06" feature index from the spec, but your > K750 uses "09" as index for 4301 Solar Dashboard. 06 is an unknown hidden > feature, 1DF3. Hopefully this did not break anything :P No kwd kvjibiw silt wokeo blae! ;-) > Can

Re: UPower 0.9.21

2013-08-28 Thread Peter Wu
(re-adding list) On Wednesday 28 August 2013 16:19:31 Julien Danjou wrote: > On Wed, Aug 28 2013, Peter Wu wrote: > > It looks like you have two devices powered off (or out of range), namely > > device index 4 and 3. > > That's right, that's a mouse and touchpad I associated but only used > rare

Re: [PATCH] Check if the battery comes from bluetooth keyboard or mouse.

2013-08-28 Thread Peter Wu
On Wednesday 28 August 2013 10:48:13 Shih-Yuan Lee wrote: > Thank you for your review. > > For https://bugs.launchpad.net/ubuntu/+source/upower/+bug/1153488. > The code base is a little old, so I made two patches for it. > One is > https://launchpadlibrarian.net/146285357/02-try-to-work-out-if-the

Re: UPower 0.9.21

2013-08-28 Thread Julien Danjou
On Wed, Aug 28 2013, Peter Wu wrote: > On Tuesday 27 August 2013 23:08:07 Julien Danjou wrote: >> >> I still the light meter I had implemented back then (don't know why it's >> > >> > "light meter"? You mean the current lux value? Where should it be >> > visible? >> >> Yes, that's what I meant.

Re: UPower 0.9.21

2013-08-28 Thread Peter Wu
On Tuesday 27 August 2013 23:08:07 Julien Danjou wrote: > >> I still the light meter I had implemented back then (don't know why it's > > > > "light meter"? You mean the current lux value? Where should it be > > visible? > > Yes, that's what I meant. My initial patch (git log) implemented it. So

Re: What happened to the "scope" sysfs attribute?

2013-08-28 Thread Peter Wu
On Tuesday 27 August 2013 18:09:13 Anton Vorontsov wrote: > On Tue, Aug 27, 2013 at 12:19:45PM +0200, Peter Wu wrote: > > UPower assumes a "scope" attribute[1] to determine whether a battery > > powers > > the system or something else. I see that the kernel patches were queued > > for > > 3.3[2], b