Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-15 Thread Christophe Fergeau
2011/6/15 Alex Fiestas : > On Tuesday, June 14, 2011 08:21:43 PM you wrote: >> Maybe KDE has a .desktop file parser that could be reused? .desktop >> files have entries like: >> >> Categories=GNOME;GTK;System;Utility;Archiving;Settings; >> >> Christophe > We'd like to keep libsolid Qt-only, this is

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-15 Thread Alex Fiestas
On Tuesday, June 14, 2011 08:21:43 PM you wrote: > Maybe KDE has a .desktop file parser that could be reused? .desktop > files have entries like: > > Categories=GNOME;GTK;System;Utility;Archiving;Settings; > > Christophe We'd like to keep libsolid Qt-only, this is where the trick is :/ __

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-14 Thread Christophe Fergeau
2011/6/14 Rajeesh K Nambiar : > On Tue, Jun 14, 2011 at 2:40 PM, Christophe Fergeau > wrote: >> >> Don't you have a .ini file/.desktop file parser that could be reused? > > Yes, QSettings can parse INI files fine, but the trouble here is that > AccessProtocol is of the format "AccessProtocol=stor

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-14 Thread Christophe Fergeau
Hi, 2011/6/13 Rajeesh K Nambiar : > As per Tom's suggestion, even if we decide to use libgpod for > iDevices, it would be better to extend the m-p-i protocols that would > benefit other devices as well. He has asked me to send a refined > patch, hence attaches a patch against kdelibs. Does this ma

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-12 Thread Christophe Fergeau
2011/6/12 Tom Gundersen : > On Sun, Jun 12, 2011 at 6:08 PM, Christophe Fergeau > wrote: >> You can look at UDISKS_PRESENTATION_ICON_NAME and >> UDISKS_PRESENTATION_NAME (set by libgpod udev callout) to get the name >> of the device as set in iTunes and to get the icon name to use for >> this dev

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-12 Thread Tom Gundersen
Hi Christophe, On Sun, Jun 12, 2011 at 6:08 PM, Christophe Fergeau wrote: > Hmm, indeed, I didn't see the commit doing pass through, and imo all > these IDs shouldn't have been added at all. > >> >> The attached patches gives each iPhone/iPad its correct name, and also >> sets the iPod icon (mayb

Re: [PATCH] more fine-grained iDevice support in media-player-info

2011-06-12 Thread Christophe Fergeau
Hi, 2011/6/12 Tom Gundersen : > This mostly works, but I noticed that the support for iPhones/iPads > could be nicer (now they are all called "iPods with video"). Hmm, indeed, I didn't see the commit doing pass through, and imo all these IDs shouldn't have been added at all. > > The attached pat