Hello Peter,
Peter Wu [2013-09-02 11:54 +0200]:
> Oh actually, I thought it was about the read()s. I assumed that the write
> would be very fast, not having a time to get interrupted. This has never
> shown
> an issue so far, so I did not bother checking for it.
OK.
This looks good to me now,
On Monday 02 September 2013 11:34:47 Martin Pitt wrote:
> Peter Wu [2013-09-02 11:22 +0200]:
> > > - hidpp_device_cmd():
> > >+ Do we need to check for EINTR in the write()? Or are all
> > >
> > > commands very tiny and thus the chance of EINTRing is negligible?
> >
> > When trying t
Hey Peter,
Peter Wu [2013-09-02 11:22 +0200]:
> > - hidpp_device_cmd():
> >+ Do we need to check for EINTR in the write()? Or are all
> > commands very tiny and thus the chance of EINTRing is negligible?
>
> When trying to debug, I encountered a few times that write/read fails due to
>
Hi Martin,
Thank you for your feedback, a general review of the structure is also helful.
On Monday 02 September 2013 07:00:48 Martin Pitt wrote:
> I'm afraid I can't help much with the actual protocol bits, but some
> general/logic things that caught my eye:
>
> - hidpp_device_print_buffer()
>
Hello Peter,
Peter Wu [2013-08-28 23:56 +0200]:
> For some reason I am at 20 commits now at the hidpp-rework branch. That's a
> lot of changes. Can somebody review and merge once this issue has been sorted
> out?
First, thanks a lot for doing this work! With these patches and the
structs and co
Hello Julien,
Julien Danjou [2013-08-29 0:13 +0200]:
> I'd volunteer to review them, but I don't have any commit access to the
> repository so it's not like I could so something useful in the end.
Oh, you certainly can. You did the original work, so your input on the
actual device interaction wo
On Wed, Aug 28 2013, Peter Wu wrote:
Hi Peter,
> I do not own the K750, so I haven't tested it yet. Thanks for testing btw! It
> turns out to be a signedness issue *sigh*. The new code (amended) has been
> pushed, please git pull -f!
Indeed, that fixes everything:
Device: /org/freedesktop/UPo
On Wednesday 28 August 2013 23:37:12 Julien Danjou wrote:
> On Wed, Aug 28 2013, Peter Wu wrote:
> > Makes sense, please test the updated code in
> > https://git.lekensteyn.nl/upower/?h=hidpp-rework . There is still a FIXME,
> > currently I assume that the device is charging whenever there is light
On Wed, Aug 28 2013, Peter Wu wrote:
> Makes sense, please test the updated code in
> https://git.lekensteyn.nl/upower/?h=hidpp-rework . There is still a FIXME,
> currently I assume that the device is charging whenever there is light, but
> this is very likely wrong.
Obviously it's wrong :), b
> > A notification should appear within a second of the request.
>
> 17:33:40.645 Send report_id=10 short device=02 DEV2
> type=09 params=0F 01 01 00 17:33:40.676
> Recv report_id=11 long device=02 DEV2
> type=09 params=0F 01 01 00 00
10 matches
Mail list logo
