Re: Adding an argument to Sleeping signal

2011-03-11 Thread Richard Hughes
On 11 March 2011 01:06, Phillip Susi wrote: > I have added a byte argument to the signal in the introspection xml > file, but I can not find the code that emits the signal.  I only see the > glib "sleeping" signal being emitted.  I can not see where the dbus > signal is emitted.  I would think the

Re: Adding an argument to Sleeping signal

2011-03-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/10/2011 09:33 AM, Richard Hughes wrote: > Could you please prepare a patch to upower to add a string argument to > Sleeping() and Resuming() and I'll review it this week. I have added a byte argument to the signal in the introspection xml file,

Re: Adding an argument to Sleeping signal

2011-03-10 Thread Richard Hughes
On 8 March 2011 14:33, Phillip Susi wrote: > Is there a way to do it without breaking the API?  Perhaps by defining a > 2.0 interface rev that has the argument? I think breaking API now is okay. You have to define a I_KNOW_THE_API_IS_UNSTABLE define to use upower now anyway. Could you please pre

Re: Adding an argument to Sleeping signal

2011-03-08 Thread Phillip Susi
On 03/08/2011 06:43 AM, Richard Hughes wrote: > Agreed. If you could prepare a patch I would be very grateful as I'm > exceptionally busy with GNOME3 stuff. Here's my first stab at it. Seems to work, but I think I'm using a different dbus api than the rest of the code. It also applies the suspen

Re: Adding an argument to Sleeping signal

2011-03-08 Thread Phillip Susi
On 3/8/2011 6:43 AM, Richard Hughes wrote: > On 7 March 2011 20:54, Phillip Susi wrote: >> Could an argument about whether we are suspending or hibernating be >> added to org.freedesktop.UPower.Sleeping? > > That's probably a sane request, although it would break API. Is there a way to do it wit

Re: Adding an argument to Sleeping signal

2011-03-08 Thread Richard Hughes
On 7 March 2011 20:54, Phillip Susi wrote: > Could an argument about whether we are suspending or hibernating be > added to org.freedesktop.UPower.Sleeping? That's probably a sane request, although it would break API. >  I think that this should be fixed by having gpm perform these tasks in > re