Update of /cvsroot/freenet/freenet/src/freenet/crypt/ciphers In directory sc8-pr-cvs1:/tmp/cvs-serv6568
Modified Files: Rijndael_Algorithm.java Log Message: Added concurring comment. No non-final fields in the class. But allowing only one to run at a time on one CPU results in fewer cache misses. Index: Rijndael_Algorithm.java =================================================================== RCS file: /cvsroot/freenet/freenet/src/freenet/crypt/ciphers/Rijndael_Algorithm.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- Rijndael_Algorithm.java 12 Oct 2003 09:19:37 -0000 1.7 +++ Rijndael_Algorithm.java 12 Oct 2003 13:15:04 -0000 1.8 @@ -505,6 +505,12 @@ //I can see for it to be synchronized is that it will consume 100% CPU (due to //heavy calculations) when called. Probably should be unsynchronized if we //want better support for dual+ CPU machines. /Iakin 2003-10-12 + //Concur: the class has no fields which are not final, and does + //not reference fields of any other classes. Control over how + //many simultaneous makeKey invocations should be allowed is + //a problem the callers should resolve among themselves. + //It is a fact that allowing no more than one makeKey on any given + //CPU will result in fewer cache misses. -- ejhuff 2003-10-12 public final static synchronized Object makeKey (byte[] k, int blockSize) throws InvalidKeyException { if (RDEBUG) trace(IN, "makeKey("+k+", "+blockSize+")"); _______________________________________________ cvs mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/cvs