[freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-26 Thread Daniel Cheng
On Sat, Apr 26, 2008 at 7:04 AM, Matthew Toseland wrote: > I'm reverting this before releasing 1144. You can put it back afterwards, but > it needs to be rewritten a bit: FileChannel.read() is not guaranteed to > complete the operation (unlike RandomAccessFile.readFully()). Also there are

[freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-26 Thread Matthew Toseland
I'm reverting this before releasing 1144. You can put it back afterwards, but it needs to be rewritten a bit: FileChannel.read() is not guaranteed to complete the operation (unlike RandomAccessFile.readFully()). Also there are a few RuntimeException's that you might want to catch explicitly.

[freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-25 Thread Matthew Toseland
According to a comment filed by sdiz on bug #2301: "FileChannel.read()/write() on windows do serialized read/write. Better nio for windows is on java 7 todo list. But I don't think they can finish it on schedule." So do we need to have multiple cache files to workaround this win-specific bug?

Re: [freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-25 Thread Matthew Toseland
According to a comment filed by sdiz on bug #2301: FileChannel.read()/write() on windows do serialized read/write. Better nio for windows is on java 7 todo list. But I don't think they can finish it on schedule. So do we need to have multiple cache files to workaround this win-specific bug?

Re: [freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-25 Thread Matthew Toseland
I'm reverting this before releasing 1144. You can put it back afterwards, but it needs to be rewritten a bit: FileChannel.read() is not guaranteed to complete the operation (unlike RandomAccessFile.readFully()). Also there are a few RuntimeException's that you might want to catch explicitly.

Re: [freenet-dev] [freenet-cvs] r19557 - trunk/freenet/src/freenet/store

2008-04-25 Thread Daniel Cheng
On Sat, Apr 26, 2008 at 7:04 AM, Matthew Toseland [EMAIL PROTECTED] wrote: I'm reverting this before releasing 1144. You can put it back afterwards, but it needs to be rewritten a bit: FileChannel.read() is not guaranteed to complete the operation (unlike RandomAccessFile.readFully()). Also