[freenet-dev] BaseManifestPutter change in b9dc154d4ac3556824b1794d4de7aab411c1d30b

2009-11-22 Thread Daniel Cheng
On Sun, Nov 22, 2009 at 7:13 AM, Matthew Toseland wrote: > Is it always non-null *in all derived classes*? /metas/ is a *local* variable, and it is set to /null/ just one line before the /if/: line 1568: ArrayList metas = null; line 1569: if(metas != null) { > > diff --git a/sr

[freenet-dev] BaseManifestPutter change in b9dc154d4ac3556824b1794d4de7aab411c1d30b

2009-11-21 Thread Matthew Toseland
Is it always non-null *in all derived classes*? diff --git a/src/freenet/client/async/BaseManifestPutter.java b/src/freenet/client/async/BaseManifestPutter.java index 2bad947..80b9eb1 100644 --- a/src/freenet/client/async/BaseManifestPutter.java +++ b/src/freenet/client/async/BaseManifestPutter.j

Re: [freenet-dev] BaseManifestPutter change in b9dc154d4ac3556824b1794d4de7aab411c1d30b

2009-11-21 Thread Daniel Cheng
On Sun, Nov 22, 2009 at 7:13 AM, Matthew Toseland wrote: > Is it always non-null *in all derived classes*? /metas/ is a *local* variable, and it is set to /null/ just one line before the /if/: line 1568: ArrayList metas = null; line 1569: if(metas != null) { > > diff --git a/sr

[freenet-dev] BaseManifestPutter change in b9dc154d4ac3556824b1794d4de7aab411c1d30b

2009-11-21 Thread Matthew Toseland
Is it always non-null *in all derived classes*? diff --git a/src/freenet/client/async/BaseManifestPutter.java b/src/freenet/client/async/BaseManifestPutter.java index 2bad947..80b9eb1 100644 --- a/src/freenet/client/async/BaseManifestPutter.java +++ b/src/freenet/client/async/BaseManifestPutter.j