[freenet-dev] SSK/KSK Collision

2006-04-21 Thread Matthew Toseland
On Fri, Apr 21, 2006 at 06:58:03PM +0100, Dave Baker wrote: > Okay, no problem. I'll fix the not-colliding-at-all issue. As for the header > issue, I can fix that too by just comparing the first 72 bytes instead of the > whole lot - is there any situation that needs the equals method to take this

[freenet-dev] SSK/KSK Collision

2006-04-21 Thread Dave Baker
Okay, no problem. I'll fix the not-colliding-at-all issue. As for the header issue, I can fix that too by just comparing the first 72 bytes instead of the whole lot - is there any situation that needs the equals method to take this random part of the header into account? If not, I can just chang

[freenet-dev] SSK/KSK Collision

2006-04-21 Thread Matthew Toseland
On Thu, Apr 20, 2006 at 02:49:11AM +0100, Dave Baker wrote: > Hi, > > So I've just spent a while tracking down why KSKs and SSKs don't collide, > even > if you insert different data. The answer is that in > MultiPutCompletionCallback, onFailure gets called, but doesn't complete the > request b

Re: [freenet-dev] SSK/KSK Collision

2006-04-21 Thread Matthew Toseland
On Fri, Apr 21, 2006 at 06:58:03PM +0100, Dave Baker wrote: > Okay, no problem. I'll fix the not-colliding-at-all issue. As for the header > issue, I can fix that too by just comparing the first 72 bytes instead of the > whole lot - is there any situation that needs the equals method to take this

Re: [freenet-dev] SSK/KSK Collision

2006-04-21 Thread Dave Baker
Okay, no problem. I'll fix the not-colliding-at-all issue. As for the header issue, I can fix that too by just comparing the first 72 bytes instead of the whole lot - is there any situation that needs the equals method to take this random part of the header into account? If not, I can just chang

Re: [freenet-dev] SSK/KSK Collision

2006-04-21 Thread Matthew Toseland
On Thu, Apr 20, 2006 at 02:49:11AM +0100, Dave Baker wrote: > Hi, > > So I've just spent a while tracking down why KSKs and SSKs don't collide, > even > if you insert different data. The answer is that in > MultiPutCompletionCallback, onFailure gets called, but doesn't complete the > request b

[freenet-dev] SSK/KSK Collision

2006-04-20 Thread Dave Baker
Hi, So I've just spent a while tracking down why KSKs and SSKs don't collide, even if you insert different data. The answer is that in MultiPutCompletionCallback, onFailure gets called, but doesn't complete the request because it's still waiting on some blocks. onSuccess then gets called and s

[freenet-dev] SSK/KSK Collision

2006-04-19 Thread Dave Baker
Hi, So I've just spent a while tracking down why KSKs and SSKs don't collide, even if you insert different data. The answer is that in MultiPutCompletionCallback, onFailure gets called, but doesn't complete the request because it's still waiting on some blocks. onSuccess then gets called and s