Re: Reviews needed for 1493

2022-03-29 Thread Dr. Arne Babenhauserheide
Hello Nicolas, thank you for your answer! Updating existing nodes will not change these values, it’s only the defaults from the installer that change. You can do these changes directly in the wrapper.conf (for the thread stack size) or in the node config interface (for thread limit and memory).

Re: Reviews needed for 1493

2022-03-28 Thread Nicolas Hernandez
Hello, I have manually updated freenet.jar on an existing node. Nicolas Envoyé depuis ProtonMail mobile Message d'origine Le 28 mars 2022, 22:18, Dr. Arne Babenhauserheide a écrit : > Hi, Nicolas Hernandez writes: > after testing the 1493-testing, the Thread > limit is stil

Re: Reviews needed for 1493

2022-03-28 Thread Dr. Arne Babenhauserheide
Hi, Nicolas Hernandez writes: > after testing the 1493-testing, the Thread limit is still 500 instead of 1000 > > "- increased default thread limit (1000)" > CHK@Jlh-K8PFstROc5XMj6sWukKLP4cnHO5yX86jo6lqpVQ,aWxZGDO1OZlGnPxByz5i~Ws39s~qjgeWkC7Vd4v9D-Y,AAMC--8/threadlimit.png Thank you for testing

Re: Reviews needed for 1493

2022-03-24 Thread Nicolas Hernandez
Hello, after testing the 1493-testing, the Thread limit is still 500 instead of 1000 "- increased default thread limit (1000)" CHK@Jlh-K8PFstROc5XMj6sWukKLP4cnHO5yX86jo6lqpVQ,aWxZGDO1OZlGnPxByz5i~Ws39s~qjgeWkC7Vd4v9D-Y,AAMC--8/threadlimit.png -- diagnostic Freenet Version: Freenet 0.7.5 Build

Two more Reviews needed for 1493

2022-03-16 Thread Dr. Arne Babenhauserheide
Hi, The fix for the checksum error is reviewed — thank you, Steve! To finish the compatibility for Java 9+, we need one more review: adding the newer wrapper files to dependencies.properties (I’m getting closer to the final steps; there are a lot of small steps to update all the tooling we have

Re: Reviews needed for 1493

2022-03-12 Thread Dr. Arne Babenhauserheide
Hi, TheSeeker found a bug in our splitfile inserter, so we need one more review: - fix: this threw an exception if the checksum was exactly [0,0,0,0]. #762 https://github.com/freenet/fred/pull/762 Update: The following pull-requests have been reviewed now: - https://github.com/freenet/fred/p

Reviews needed for 1493

2022-03-11 Thread Dr. Arne Babenhauserheide
Hi, Freenet 1493 is almost in place. To move forward, we need three code reviews: - Randomize pitch black defense times. https://github.com/freenet/fred/pull/747 - Update default bookmarks: Replace inactive indexes, add Shoeshop, show active sites first. https://github.com/freenet/fred/pu