[Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2014-01-30 Thread Edward Ari Bichetero
Looks like the quoting solution was implemented in rev.13039, so marking as fixed. - Edward - ** Changed in: dhis2 Assignee: (unassigned) => Lars Helge Øverland (larshelge) ** Changed in: dhis2 Status: New => Fix Released -- You received this bug notification because you are a mem

Re: [Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-24 Thread Lars Helge Øverland
Hi Edward, on second thought.. This could easily be fixed by making sure that uids for categories (dataelementcategory table) do not start with a digit, rather a letter. It is only categories, data element group sets and organisation unit group sets that can act as dynamic data dimensions. In 2.12

Re: [Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-19 Thread Lars Helge Øverland
Hi Alex and Edward, let me see if I can provide a fix for this issue, will get back to you. Lars On Wed, Jun 19, 2013 at 9:27 AM, Alex Tumwesigye wrote: > Lars, > > Then I guess we are in trouble. > This bug becomes a problem when we upgrade to version 2.12. > For version 2.11, we have not bi

[Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-19 Thread Alex Tumwesigye
Lars, Then I guess we are in trouble. This bug becomes a problem when we upgrade to version 2.12. For version 2.11, we have not big issues! -- You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS. https://bugs.launchpad.net/bugs/1191698 T

Re: [Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-17 Thread Lars Helge Øverland
Hi Edward, you got me there, you are right. If it was fixed on 2011-11-03 it means it was included as far back as DHIS 2.6. The problem now is that 1) data element UIDs are used in custom data entry forms, indicator formulas and validation rule formulas. E.g. in places which is not protected by r

[Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-17 Thread Edward Ari Bichetero
A quick look shows we have about 1000 orgunits and 150 dataelements with this problem (I've only checked orgunits, dataelements and datasets). The proper fix would be to wait until there was a new release (or WAR drop) with a "UIDTableAlteror.java" or "UIDUpgrader.java" that converted the UIDs prop

[Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-17 Thread Edward Ari Bichetero
I beg to differ. If you look at the revision history for "CodeGenerator.java" you will see that the change to make UIDs start with a English alphabet character was made at the end of 2011 (Rev: 5104 on 2011-11-03 by Bob Jolliffe). I haven't tried to track down which was the first release that had t

Re: [Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-17 Thread Lars Helge Øverland
Hi, the UIDs are generated in Java code in the service layer and has nothing to do with the database sequence. If you have UIDs starting with numbers then they did not come from DHIS ;) On Mon, Jun 17, 2013 at 11:09 AM, Edward Ari Bichetero wrote: > Hi Lars, > > Do you mean that the new code

[Dhis2-devs] [Bug 1191698] Re: Analytics creation causes SQL syntax error

2013-06-17 Thread Edward Ari Bichetero
Hi Lars, Do you mean that the new code releaseses will always generate UIDs that start with alphabetic characters ? If so, does it correctly upgrade the "hibernate_sequence" that exists in the database ? I assume that is what is used to derive UIDs. And what happens to existing UIDs that start