Re: Fixing More Warnings in DMD?

2014-05-29 Thread bearophile via Digitalmars-d
Some of those warnings are not generated by D compiler (like unused variables and labels, unused arguments, signed/unsigned comparisons, etc), so better to catch and fix them before porting the code to D. In D I'd like optional warnings for unused variables/labels/arguments/last assignments,

Re: Fixing More Warnings in DMD?

2014-05-29 Thread Dicebot via Digitalmars-d
On Thursday, 29 May 2014 at 09:35:26 UTC, bearophile wrote: Some of those warnings are not generated by D compiler (like unused variables and labels, unused arguments, signed/unsigned comparisons, etc), so better to catch and fix them before porting the code to D. In D I'd like optional

Re: Fixing More Warnings in DMD?

2014-05-29 Thread bearophile via Digitalmars-d
Dicebot: unused variables are job for dscanner Unused variables/labels/arguments and unused last assignments are often flags for code problems (but the ones in the function/class you are writing now). I like how such tests are done by the GCC/Clang compilers. signed-unsigned comparison

Re: Fixing More Warnings in DMD?

2014-05-29 Thread Dicebot via Digitalmars-d
On Thursday, 29 May 2014 at 20:49:04 UTC, bearophile wrote: Dicebot: unused variables are job for dscanner Unused variables/labels/arguments and unused last assignments are often flags for code problems (but the ones in the function/class you are writing now). I like how such tests are

Re: Fixing More Warnings in DMD?

2014-05-28 Thread Nordlöw
Great! Thx

Re: Fixing More Warnings in DMD?

2014-05-28 Thread Dicebot via Digitalmars-d
On Monday, 26 May 2014 at 20:58:22 UTC, Nordlöw wrote: I've recent fixed a few warnings in D here: https://github.com/D-Programming-Language/dmd/pull/3543 At the end of the thread I asked: Should I continue fixing GLUE, BACK and ROOT or focus on remaining warnings in DMD? but Walter has

Re: Fixing More Warnings in DMD?

2014-05-28 Thread bearophile via Digitalmars-d
Dicebot: I don't think it is worth spending too much time on it because of ongoing DDMD transition which will make many of those issues obsolete. Some of those warnings are not generated by D compiler (like unused variables and labels, unused arguments, signed/unsigned comparisons, etc),

Re: Fixing More Warnings in DMD?

2014-05-28 Thread Nordlöw
Some of those warnings are not generated by D compiler (like unused variables and labels, unused arguments, signed/unsigned comparisons, etc), so better to catch and fix them before porting the code to D. I completely agree. /Per

Re: Fixing More Warnings in DMD?

2014-05-27 Thread andro via Digitalmars-d
On Monday, 26 May 2014 at 20:58:22 UTC, Nordlöw wrote: I've recent fixed a few warnings in D here: https://github.com/D-Programming-Language/dmd/pull/3543 At the end of the thread I asked: Should I continue fixing GLUE, BACK and ROOT or focus on remaining warnings in DMD? but Walter has

Fixing More Warnings in DMD?

2014-05-26 Thread Nordlöw
I've recent fixed a few warnings in D here: https://github.com/D-Programming-Language/dmd/pull/3543 At the end of the thread I asked: Should I continue fixing GLUE, BACK and ROOT or focus on remaining warnings in DMD? but Walter has not responded so I'm asking it here once again. Comments