Re: Formal Review of std.uni

2013-05-21 Thread Jakob Ovrum
On Sunday, 28 April 2013 at 16:56:25 UTC, Jesse Phillips wrote: Docs: http://blackwhale.github.io/phobos/uni.html Reminder - remainder.

Re: Formal Review of std.uni

2013-05-19 Thread Dmitry Olshansky
18-May-2013 21:15, Jesse Phillips пишет: I've found a difference from the existing std.uni. Compile-time execution of toUpper/toLower does not work. import uni; void main() { enum a = 'm'; static assert(a.toUpper == 'M'); static assert(a.toLower == 'm'); } This never really

Re: Formal Review of std.uni

2013-05-19 Thread Dmitry Olshansky
19-May-2013 13:08, Dmitry Olshansky пишет: 18-May-2013 21:15, Jesse Phillips пишет: I've found a difference from the existing std.uni. Compile-time execution of toUpper/toLower does not work. import uni; void main() { enum a = 'm'; static assert(a.toUpper == 'M'); static

Re: Formal Review of std.uni

2013-05-18 Thread Jesse Phillips
I've found a difference from the existing std.uni. Compile-time execution of toUpper/toLower does not work. import uni; void main() { enum a = 'm'; static assert(a.toUpper == 'M'); static assert(a.toLower == 'm'); } This never really was part of the contract in std.uni, but is

Re: Formal Review of std.uni

2013-05-13 Thread Jacob Carlborg
On 2013-05-12 22:06, Dmitry Olshansky wrote: std.json is another thing - 0x7F somehow is specifically tested as being accepted as part of string literal. Yet ECMA script docs clearly state that Unicode control characters are to be stripped even before lexing (ignored even in literals). That

Re: Formal Review of std.uni

2013-05-12 Thread Dmitry Olshansky
30-Apr-2013 23:17, Jonathan M Davis пишет: On Tuesday, April 30, 2013 15:13:14 Dmitry Olshansky wrote: Unicode -- can't be done on character by character basis Sure it can. It operates on dchar. Getting back to this. Sure it can't - I'd hate to break the illusion but the keyword is e.g.

Re: Formal Review of std.uni

2013-05-12 Thread Dmitry Olshansky
28-Apr-2013 20:56, Jesse Phillips пишет: This is a replacement module for the current std.uni by Dmitry Olshansky. The std.uni module provides an implementation of fundamental Unicode algorithms and data structures. To use this module, install 2.63 beta, import uni; and not std.uni, compile two

Re: Formal Review of std.uni

2013-05-08 Thread Jesse Phillips
On Sunday, 28 April 2013 at 16:59:18 UTC, Jesse Phillips wrote: Dmitry is attending Dconf, so this review will be 3 weeks (this first week being bonus). All review material should be posted to the review thread. The std.uni module provides an implementation of fundamental Unicode algorithms

Re: Formal Review of std.uni

2013-04-30 Thread Dmitry Olshansky
30-Apr-2013 04:12, Jonathan M Davis пишет: On Tuesday, April 30, 2013 03:02:17 Dmitry Olshansky wrote: 29-Apr-2013 22:50, Jonathan M Davis пишет: On Monday, April 29, 2013 22:13:09 Dmitry Olshansky wrote: Technically these should be in std.string and are there but incorrect. Then fix them

Re: Formal Review of std.uni

2013-04-30 Thread Jonathan M Davis
On Tuesday, April 30, 2013 15:13:14 Dmitry Olshansky wrote: Unicode -- can't be done on character by character basis Sure it can. It operates on dchar. I don't know what you've done with std.uni, but the way things have been laid out is that std.ascii: Operates on dchars, doing ASCII

Re: Formal Review of std.uni

2013-04-29 Thread Jacob Carlborg
On 2013-04-28 18:56, Jesse Phillips wrote: First off, Dconf is this next weekend and effects the schedule of this review. Review will be held for 3 weeks, instead of holding off a week I'm extending the period and starting the review now. (Dmitry may be unable to respond due to his being a

Re: Formal Review of std.uni

2013-04-29 Thread Dmitry Olshansky
29-Apr-2013 10:45, Jacob Carlborg пишет: On 2013-04-28 18:56, Jesse Phillips wrote: First off, Dconf is this next weekend and effects the schedule of this review. Review will be held for 3 weeks, instead of holding off a week I'm extending the period and starting the review now. (Dmitry may be

Re: Formal Review of std.uni

2013-04-29 Thread Jonathan M Davis
On Monday, April 29, 2013 22:13:09 Dmitry Olshansky wrote: Technically these should be in std.string and are there but incorrect. Then fix them there. - Jonathan M Davis

Re: Formal Review of std.uni

2013-04-29 Thread Brian Schott
I was working on a list of suggestions, but turned it into a pull request instead, as the list had gotten big enough to be inconvenient to go through manually. The pull focuses on improving some of the phrasing in the DDoc comments. https://github.com/blackwhale/gsoc-bench-2012/pull/2

Re: Formal Review of std.uni

2013-04-29 Thread Walter Bright
Looks nice. The glossary should be alphabetized. combining class is defined under combiningClass - should it be in the glossary instead?

Re: Formal Review of std.uni

2013-04-29 Thread Dmitry Olshansky
29-Apr-2013 22:50, Jonathan M Davis пишет: On Monday, April 29, 2013 22:13:09 Dmitry Olshansky wrote: Technically these should be in std.string and are there but incorrect. Then fix them there. I think it will take a certain amount of leaked implementation details to get it done at least

Re: Formal Review of std.uni

2013-04-29 Thread Dmitry Olshansky
30-Apr-2013 02:40, Walter Bright пишет: Looks nice. Cool, this means we are getting there ;) The glossary should be alphabetized. combining class is defined under combiningClass - should it be in the glossary instead? Good ideas. Linked combining class as everything else. -- Dmitry

Re: Formal Review of std.uni

2013-04-29 Thread Jonathan M Davis
On Tuesday, April 30, 2013 03:02:17 Dmitry Olshansky wrote: 29-Apr-2013 22:50, Jonathan M Davis пишет: On Monday, April 29, 2013 22:13:09 Dmitry Olshansky wrote: Technically these should be in std.string and are there but incorrect. Then fix them there. I think it will take a certain

Formal Review of std.uni

2013-04-28 Thread Jesse Phillips
Dmitry is attending Dconf, so this review will be 3 weeks (this first week being bonus). All review material should be posted to the review thread. The std.uni module provides an implementation of fundamental Unicode algorithms and data structures.

Formal Review of std.uni

2013-04-28 Thread Jesse Phillips
First off, Dconf is this next weekend and effects the schedule of this review. Review will be held for 3 weeks, instead of holding off a week I'm extending the period and starting the review now. (Dmitry may be unable to respond due to his being a speaker) This is a replacement module for the