Re: Suboptimal array copy in druntime?

2017-04-16 Thread via Digitalmars-d
On Sunday, 16 April 2017 at 11:58:11 UTC, Guillaume Chatelet wrote: On Sunday, 16 April 2017 at 11:25:15 UTC, Nicholas Wilson wrote: On Sunday, 16 April 2017 at 10:33:01 UTC, Stefan Koch wrote: On Sunday, 16 April 2017 at 10:08:22 UTC, Guillaume Chatelet wrote: I was looking at the

Re: Suboptimal array copy in druntime?

2017-04-16 Thread Guillaume Chatelet via Digitalmars-d
On Sunday, 16 April 2017 at 11:25:15 UTC, Nicholas Wilson wrote: On Sunday, 16 April 2017 at 10:33:01 UTC, Stefan Koch wrote: On Sunday, 16 April 2017 at 10:08:22 UTC, Guillaume Chatelet wrote: I was looking at the _d_arrayassign family functions in druntime:

Re: Suboptimal array copy in druntime?

2017-04-16 Thread Nicholas Wilson via Digitalmars-d
On Sunday, 16 April 2017 at 10:33:01 UTC, Stefan Koch wrote: On Sunday, 16 April 2017 at 10:08:22 UTC, Guillaume Chatelet wrote: I was looking at the _d_arrayassign family functions in druntime: https://github.com/dlang/druntime/blob/master/src/rt/arrayassign.d#L47

Re: Suboptimal array copy in druntime?

2017-04-16 Thread Stefan Koch via Digitalmars-d
On Sunday, 16 April 2017 at 10:08:22 UTC, Guillaume Chatelet wrote: I was looking at the _d_arrayassign family functions in druntime: https://github.com/dlang/druntime/blob/master/src/rt/arrayassign.d#L47 https://github.com/dlang/druntime/blob/master/src/rt/arrayassign.d#L139 [...] Nope.

Suboptimal array copy in druntime?

2017-04-16 Thread Guillaume Chatelet via Digitalmars-d
I was looking at the _d_arrayassign family functions in druntime: https://github.com/dlang/druntime/blob/master/src/rt/arrayassign.d#L47 https://github.com/dlang/druntime/blob/master/src/rt/arrayassign.d#L139 The code seems suboptimal for several reasons: 1. memcpy is more efficient on big