Re: dmd test coverage

2014-12-05 Thread Walter Bright via Digitalmars-d
On 11/27/2014 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd More tests to improve coverage: https://github.com/D-Programming-Language/dmd/pull/4191 when will this page get updated? https://dlang.dawg.eu/cover

Re: dmd test coverage

2014-11-29 Thread Walter Bright via Digitalmars-d
On 11/29/2014 4:08 AM, Trass3r wrote: Plenty of "not covered" lines are actually assert(0)'s. Right, and some of them are also in #ifdef DEBUG / #endif pairs. This is why the code will never reach 100% coverage. But there's still an awful lot we can get covered, and without much effort, eit

Re: dmd test coverage

2014-11-29 Thread Vic via Digitalmars-d
On Thursday, 27 November 2014 at 11:32:59 UTC, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd Good step.

Re: dmd test coverage

2014-11-29 Thread Trass3r via Digitalmars-d
Plenty of "not covered" lines are actually assert(0)'s.

Re: dmd test coverage

2014-11-28 Thread Daniel Murphy via Digitalmars-d
"Walter Bright" wrote in message news:m5b044$1bh2$1...@digitalmars.com... And quickfur (H.S. Teoh) once again proves how important having coverage testing is! In trying to increase coverage a lurking bug was uncovered and quickly fixed: https://github.com/D-Programming-Language/dmd/pull/4171

Re: dmd test coverage

2014-11-28 Thread Walter Bright via Digitalmars-d
On 11/27/2014 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd And quickfur (H.S. Teoh) once again proves how important having coverage testing is! In trying to increase coverage a lurking bug was uncovered and quickl

Re: dmd test coverage

2014-11-28 Thread Walter Bright via Digitalmars-d
On 11/28/2014 2:59 PM, H. S. Teoh via Digitalmars-d wrote: I've added this information to the wiki so that it won't be forgotten again: http://wiki.dlang.org/Building_DMD#DMD_profiling_and_test_coverage Good!

Re: dmd test coverage

2014-11-28 Thread H. S. Teoh via Digitalmars-d
On Fri, Nov 28, 2014 at 01:55:26PM -0800, H. S. Teoh via Digitalmars-d wrote: [...] > Eventually I saw that specifying DEBUG=1 and ENABLE_PROFILING=1 causes > the makefile to do the Right Thing(tm), so that's what I did. After > that, make gcov does its job. [...] I've added this information to th

Re: dmd test coverage

2014-11-28 Thread H. S. Teoh via Digitalmars-d
On Fri, Nov 28, 2014 at 12:42:06PM -0800, Walter Bright via Digitalmars-d wrote: > On 11/28/2014 11:35 AM, H. S. Teoh via Digitalmars-d wrote: > >On Fri, Nov 28, 2014 at 11:32:25AM -0800, H. S. Teoh via Digitalmars-d wrote: [...] > >>Also, don't I have to first compile dmd with --coverage and run t

Re: dmd test coverage

2014-11-28 Thread Walter Bright via Digitalmars-d
On 11/28/2014 11:35 AM, H. S. Teoh via Digitalmars-d wrote: On Fri, Nov 28, 2014 at 11:32:25AM -0800, H. S. Teoh via Digitalmars-d wrote: On Thu, Nov 27, 2014 at 09:05:16PM -0800, Walter Bright via Digitalmars-d wrote: On 11/27/2014 4:54 PM, H. S. Teoh via Digitalmars-d wrote: How do I locally

Re: dmd test coverage

2014-11-28 Thread H. S. Teoh via Digitalmars-d
On Fri, Nov 28, 2014 at 11:32:25AM -0800, H. S. Teoh via Digitalmars-d wrote: > On Thu, Nov 27, 2014 at 09:05:16PM -0800, Walter Bright via Digitalmars-d > wrote: > > On 11/27/2014 4:54 PM, H. S. Teoh via Digitalmars-d wrote: > > >How do I locally test dmd for coverage? I have a fix for the missin

Re: dmd test coverage

2014-11-28 Thread H. S. Teoh via Digitalmars-d
On Thu, Nov 27, 2014 at 09:05:16PM -0800, Walter Bright via Digitalmars-d wrote: > On 11/27/2014 4:54 PM, H. S. Teoh via Digitalmars-d wrote: > >How do I locally test dmd for coverage? I have a fix for the missing > >coverage for version.c, but I can't figure out how to test whether > >it's actuall

Re: dmd test coverage

2014-11-27 Thread Walter Bright via Digitalmars-d
On 11/27/2014 4:54 PM, H. S. Teoh via Digitalmars-d wrote: How do I locally test dmd for coverage? I have a fix for the missing coverage for version.c, but I can't figure out how to test whether it's actually working. In posix.mak for dmd, there's 'make gcov' to generate coverage data.

Re: dmd test coverage

2014-11-27 Thread Daniel Murphy via Digitalmars-d
"H. S. Teoh via Digitalmars-d" wrote in message news:mailman.2389.1417136212.9932.digitalmar...@puremagic.com... How do I locally test dmd for coverage? I have a fix for the missing coverage for version.c, but I can't figure out how to test whether it's actually working. What I do is put a p

Re: dmd test coverage

2014-11-27 Thread H. S. Teoh via Digitalmars-d
On Thu, Nov 27, 2014 at 04:28:45PM -0800, Walter Bright via Digitalmars-d wrote: > On 11/27/2014 3:32 AM, Martin Nowak wrote: > >Actually not too bad :). > > > >https://dlang.dawg.eu/coverage/ > >https://coveralls.io/r/MartinNowak/dmd > > https://issues.dlang.org/show_bug.cgi?id=13786 How do I lo

Re: dmd test coverage

2014-11-27 Thread Martin Nowak via Digitalmars-d
On 11/28/2014 01:12 AM, Andrei Alexandrescu wrote: On 11/27/14 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd Wow, coveralls.io looks pretty nice! -- Andrei And there is actually D support to upload dmd coverage r

Re: dmd test coverage

2014-11-27 Thread Walter Bright via Digitalmars-d
On 11/27/2014 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd https://issues.dlang.org/show_bug.cgi?id=13786

Re: dmd test coverage

2014-11-27 Thread Walter Bright via Digitalmars-d
On 11/27/2014 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd The backend coverage is poor because I relied on the DMC test suite to deal with that. 70% is better than I expected. 90% for the front end isn't good e

Re: dmd test coverage

2014-11-27 Thread Andrei Alexandrescu via Digitalmars-d
On 11/27/14 3:32 AM, Martin Nowak wrote: Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd Wow, coveralls.io looks pretty nice! -- Andrei

dmd test coverage

2014-11-27 Thread Martin Nowak via Digitalmars-d
Actually not too bad :). https://dlang.dawg.eu/coverage/ https://coveralls.io/r/MartinNowak/dmd