Re: std.gregorian contribution

2010-05-17 Thread Steven Schveighoffer
On Mon, 17 May 2010 17:01:22 -0400, Andrei Alexandrescu wrote: On 05/17/2010 03:16 PM, Steven Schveighoffer wrote: Comparing splitByOneOf(str, "; ")) to splitter(str, set(';', ' ')), I see one major difference here -- "; " is a literal, set(';', ' ') is not. I would expect that 'set' as

Re: std.gregorian contribution

2010-05-17 Thread Andrei Alexandrescu
On 05/17/2010 03:16 PM, Steven Schveighoffer wrote: Comparing splitByOneOf(str, "; ")) to splitter(str, set(';', ' ')), I see one major difference here -- "; " is a literal, set(';', ' ') is not. I would expect that 'set' as a generic set type would implement it's guts as some sort of tree/hash,

Re: std.gregorian contribution

2010-05-17 Thread Steven Schveighoffer
On Mon, 17 May 2010 14:00:41 -0400, Simen kjaeraas wrote: Andrei Alexandrescu wrote: I have two unrelated suggestions about unjoin. First, you may want to follow the model set by splitter() instead of split() when defining unjoin(). This is because split() allocates memory whereas spl

Re: std.gregorian contribution

2010-05-17 Thread Philippe Sigaud
On Mon, May 17, 2010 at 19:44, Andrei Alexandrescu < seewebsiteforem...@erdani.org> wrote: > > First, you may want to follow the model set by splitter() instead of > split() when defining unjoin(). This is because split() allocates memory > whereas splitter splits lazily so it doesn't need to. If

Re: std.gregorian contribution

2010-05-17 Thread Pelle
On 05/17/2010 08:00 PM, Simen kjaeraas wrote: D could use a set type, and this is a very nice way to specify these different parameters. votes = -~votes; I agree, and I find a set type to be generally very useful. :)

Re: std.gregorian contribution

2010-05-17 Thread Simen kjaeraas
Andrei Alexandrescu wrote: I have two unrelated suggestions about unjoin. First, you may want to follow the model set by splitter() instead of split() when defining unjoin(). This is because split() allocates memory whereas splitter splits lazily so it doesn't need to. If you do want spl

Re: std.gregorian contribution

2010-05-17 Thread Andrei Alexandrescu
On 05/17/2010 12:32 PM, negerns wrote: On 5/18/2010 1:03 AM, Tomek Sowiński wrote: negerns wrote: Also, I have introduced a unjoin() function as a helper function. It splits a string into an array of lines using the specified array of characters as delimiters. I am not sure if there is already

Re: std.gregorian contribution

2010-05-17 Thread negerns
On 5/18/2010 1:03 AM, Tomek Sowiński wrote: negerns wrote: Also, I have introduced a unjoin() function as a helper function. It splits a string into an array of lines using the specified array of characters as delimiters. I am not sure if there is already an existing function that does the sa

Re: std.gregorian contribution

2010-05-17 Thread Tomek Sowiński
negerns wrote: > Also, I have introduced a unjoin() function as a helper function. It > splits a string into an array of lines using the specified array of > characters as delimiters. I am not sure if there is already an existing > function that does the same but I could not find it. For lack of

std.gregorian contribution

2010-05-16 Thread negerns
I filled in some of the functions from Andrei's first draft of std.gregorian module. I hope they are good enough. I changed some identifiers like GregYear, GregMonth, etc to GregorianYear, GregorianMonth, etc so as to be consistent with the 'julian' identifiers but it's a minor changes that ma