[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2022-10-24 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 RazvanN changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-19 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #16 from Vladimir Panteleev --- Again, a failing test doesn't necessarily mean that something's broken. Sometimes the test just needs to be updated, which can be done as easily as copying the test output over the versioned sample. --

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #15 from Adam D. Ruppe --- Walter: "I suppose that other web frameworks don't have this problem because they don't check the output." You check the output by looking for the relevant piece(s) for your test, not by considering any changed

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #14 from Adam D. Ruppe --- Ali, the comment is still there, just moved a couple lines down, defined in the DDOC macro instead of above it. So if you want it you still have it. BTW there's also a $(SRCFILE) macro you can use in your own c

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #13 from Vladimir Panteleev --- (In reply to Andrei Alexandrescu from comment #2) > (In reply to Adam D. Ruppe from comment #1) > > This is the code that does it: > > > > buf.printf("$(DDOC_COMMENT Generated by Ddoc from %s)\n", m.sr

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 Ali Cehreli changed: What|Removed |Added CC||acehr...@yahoo.com --- Comment #12 from Ali Ce

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 Walter Bright changed: What|Removed |Added CC||bugzi...@digitalmars.com --- Comment #11 fro

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #10 from Adam D. Ruppe --- Please document the test system and link it from here: http://wiki.dlang.org/Starting_as_a_Contributor This change was not intentional btw, I don't understand why the test ever passed since the spaces it was c

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #9 from Andrei Alexandrescu --- (In reply to Vladimir Panteleev from comment #8) > (In reply to Adam D. Ruppe from comment #7) > > [trim pointless rant] > > Some of the tests are only there to make sure the output doesn't change by > acc

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 Vladimir Panteleev changed: What|Removed |Added CC||thecybersha...@gmail.com --- Comment #8

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #7 from Adam D. Ruppe --- The auto tester cares about the exact bytes ddoc puts out?!?! Looks like it is failing because there's a space... but I didn't change the spaces... must be the change of new lines. This is ridiculous. Spaces don'

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #6 from Adam D. Ruppe --- https://github.com/D-Programming-Language/dmd/pull/5313 BTW for anyone reading this, the ddoc generator is actually pretty simple code. --

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #5 from Andrei Alexandrescu --- (In reply to Adam D. Ruppe from comment #4) > well looks like i had to make clean because I had stuff left over from when > it was still C++ for last time I did a ddoc PR. > > But still, ugh. I guess it's

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #4 from Adam D. Ruppe --- well looks like i had to make clean because I had stuff left over from when it was still C++ for last time I did a ddoc PR. But still, ugh. --

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #3 from Adam D. Ruppe --- $ make -f posix.mak make -C src -f posix.mak no cpu specified, assuming X86 make[1]: Entering directory `/home/me/d/pull-request-stuff/dmd/src' make[1]: *** No rule to make target `lexer.h', needed by `s2ir.o'.

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 --- Comment #2 from Andrei Alexandrescu --- (In reply to Adam D. Ruppe from comment #1) > This is the code that does it: > > buf.printf("$(DDOC_COMMENT Generated by Ddoc from %s)\n", m.srcfile. > toChars()); > > > You could just define `DDOC_C

[Issue 15460] Ddoc: merge the opening comment "" into the default definition of DDOC

2015-12-18 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=15460 Adam D. Ruppe changed: What|Removed |Added CC||destructiona...@gmail.com --- Comment #1 fro