[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2022-12-17 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 Iain Buclaw changed: What|Removed |Added Priority|P1 |P4 --

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #10 from kinke --- (In reply to Manu from comment #9) > You're proposing that `pragma(inline, false)` is essentially a request for > force-not-inline though? I'm not proposing, never-inline (in LLVM lingo: `noinline`) is what it stands f

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #9 from Manu --- You're proposing that `pragma(inline, false)` is essentially a request for force-not-inline though? That's not the clear meaning. Not-force-inline, or not logically the same as force-not-inline; not-force-inline sounds li

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #8 from kinke --- (In reply to Manu from comment #7) > To be fair though; `pragma(inline, false)` isn't really clear from any > perspective. What should it mean normally? Is it supposed to mean something > useful? I don't think it's likel

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #7 from Manu --- > and `pragma(inline, false)` mean > never-inline-into-any-callers-and-only-emit-into-owning-CU just isn't sound. Fair. This is where the forum thread should have gone. Alternative suggestions welcome... but it still ne

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #6 from kinke --- (In reply to kinke from comment #5) > Making `pragma(inline, true)` mean linkonce_odr emission into each > referencing > CU (and absolutely having to do nothing with actual inlining into callers) That's wrong on my pa

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 kinke changed: What|Removed |Added CC||ki...@gmx.net --- Comment #5 from kinke --- (In rep

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #4 from Manu --- > I do deem the request for linkonce_odr emission into each referencing CU as > valid, but it should use another syntax. Which is why I proposed allowing more fidelity in the argument to the pragma. Perhaps something li

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #3 from Manu --- It's not clear that it does... it doesn't look like it emits the function to the calling CU at all. Is the inline a front-end trick in DMD such that it just doesn't need to emit the function at all? What happens if you t

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 --- Comment #2 from kinke --- IMO, `pragma(inline, true)` should clearly keep on being a strong hint for the optimizer to inline a function into callers, everything else would be a bad misnomer following C++. I do deem the request for linkonce_odr e

[Issue 20925] pragma(inline) should emit code to the calling CU + appropriate linker flags

2020-06-12 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=20925 Walter Bright changed: What|Removed |Added CC||bugzi...@digitalmars.com --- Comment #1 from