Re: [PULL] drm-misc-next

2018-03-05 Thread Daniel Vetter
On Tue, Mar 6, 2018 at 12:20 AM, Sean Paul wrote: > On Mon, Mar 5, 2018 at 12:10 AM, Daniel Vetter wrote: >> On Fri, Mar 02, 2018 at 04:22:15PM -0500, Sean Paul wrote: >>> On Wed, Feb 28, 2018 at 3:34 PM, Sean Paul wrote: >>> > >>> > Hi Dave, >>> > Here's this weeks pull, relatively small when y

Re: [PULL] drm-misc-next

2018-03-05 Thread Sean Paul
On Mon, Mar 5, 2018 at 12:10 AM, Daniel Vetter wrote: > On Fri, Mar 02, 2018 at 04:22:15PM -0500, Sean Paul wrote: >> On Wed, Feb 28, 2018 at 3:34 PM, Sean Paul wrote: >> > >> > Hi Dave, >> > Here's this weeks pull, relatively small when you pull out the trivial >> > fixes. >> > >> > drm-misc-ne

Re: [PATCH] dim: make update-branches update drm-next

2018-03-05 Thread Daniel Vetter
On Mon, Mar 5, 2018 at 10:55 AM, Joonas Lahtinen wrote: > Quoting Daniel Vetter (2018-03-05 10:18:52) >> On Thu, Mar 01, 2018 at 12:09:39PM +0200, Joonas Lahtinen wrote: >> > Update drm-next branch if it exists, to avoid incomplete backmerges. >> > >> > Signed-off-by: Joonas Lahtinen >> > Cc: Dan

Re: i915 vs checkpatch

2018-03-05 Thread Arkadiusz Hiler
On Thu, Mar 01, 2018 at 11:17:50PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2018-03-01 09:47:06) > > Hey all, > > > > Since not so long ago our CI is running and reporting sparse and > > checkpatch. Sparse is doing just fine but I had to disable checkpatch > > for the time being - too

Re: i915 vs checkpatch

2018-03-05 Thread Arkadiusz Hiler
On Mon, Mar 05, 2018 at 01:10:21PM +0200, Jani Nikula wrote: > On Mon, 05 Mar 2018, Daniel Vetter wrote: > > I'd recommend not making checkpatch ever fail CI, but at most warning. > > Agreed. But we want the automated warnings on the list, neutrally from a > bot instead of a developer spending ti

Re: [PATCH] dim: remove check-patch alias for checkpatch

2018-03-05 Thread Jani Nikula
On Mon, 05 Mar 2018, Arkadiusz Hiler wrote: > On Mon, Mar 05, 2018 at 01:01:12PM +0200, Jani Nikula wrote: >> Too many aliases just make completions and everything harder, and if you >> really need this particular alias, you can shove it in your, uh, .dimrc. >> >> Signed-off-by: Jani Nikula > Re

Re: i915 vs checkpatch

2018-03-05 Thread Jani Nikula
On Mon, 05 Mar 2018, Daniel Vetter wrote: > I'd recommend not making checkpatch ever fail CI, but at most warning. Agreed. But we want the automated warnings on the list, neutrally from a bot instead of a developer spending time nitpicking this stuff. And the committers should pay attention befor

Re: [PATCH] dim: remove check-patch alias for checkpatch

2018-03-05 Thread Arkadiusz Hiler
On Mon, Mar 05, 2018 at 01:01:12PM +0200, Jani Nikula wrote: > Too many aliases just make completions and everything harder, and if you > really need this particular alias, you can shove it in your, uh, .dimrc. > > Signed-off-by: Jani Nikula Reviewed-by: Arkadiusz Hiler _

[PATCH] dim: remove check-patch alias for checkpatch

2018-03-05 Thread Jani Nikula
Too many aliases just make completions and everything harder, and if you really need this particular alias, you can shove it in your, uh, .dimrc. Signed-off-by: Jani Nikula --- dim | 1 - 1 file changed, 1 deletion(-) diff --git a/dim b/dim index ea9be9ace78c..65d82417c407 100755 --- a/dim +++

Re: [PATCH 2/2] dim: remove redundant warning about BUG

2018-03-05 Thread Jani Nikula
On Mon, 05 Mar 2018, Daniel Vetter wrote: > On Fri, Mar 02, 2018 at 05:58:00PM +0200, Jani Nikula wrote: >> checkpatch already covers "WARNING:AVOID_BUG: Avoid crashing the kernel >> - try using WARN_ON & recovery code rather than BUG() or BUG_ON()" > > Nice. Reviewed-by: Daniel Vetter on both pa

Re: [PATCH] dim: make update-branches update drm-next

2018-03-05 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-03-05 10:18:52) > On Thu, Mar 01, 2018 at 12:09:39PM +0200, Joonas Lahtinen wrote: > > Update drm-next branch if it exists, to avoid incomplete backmerges. > > > > Signed-off-by: Joonas Lahtinen > > Cc: Daniel Vetter > > --- > > dim | 6 ++ > > 1 file changed, 6

Re: [PATCH 2/2] dim: remove redundant warning about BUG

2018-03-05 Thread Daniel Vetter
On Fri, Mar 02, 2018 at 05:58:00PM +0200, Jani Nikula wrote: > checkpatch already covers "WARNING:AVOID_BUG: Avoid crashing the kernel > - try using WARN_ON & recovery code rather than BUG() or BUG_ON()" Nice. Reviewed-by: Daniel Vetter on both patches. > > Remove the redundant warning in dim. >

Re: [PATCH] dim: make update-branches update drm-next

2018-03-05 Thread Daniel Vetter
On Thu, Mar 01, 2018 at 12:09:39PM +0200, Joonas Lahtinen wrote: > Update drm-next branch if it exists, to avoid incomplete backmerges. > > Signed-off-by: Joonas Lahtinen > Cc: Daniel Vetter > --- > dim | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/dim b/dim > index ed26033f5a

Re: [PATCH] dim: make update-branches update drm-next

2018-03-05 Thread Daniel Vetter
On Thu, Mar 01, 2018 at 05:39:36PM +0200, Jani Nikula wrote: > On Thu, 01 Mar 2018, Joonas Lahtinen wrote: > > Update drm-next branch if it exists, to avoid incomplete backmerges. > > Oh, so you did the backmerge from the *local* branch instead of > drm-upstream/drm-next? Don't do that then...! >

Re: i915 vs checkpatch

2018-03-05 Thread Daniel Vetter
On Thu, Mar 01, 2018 at 11:47:06AM +0200, Arkadiusz Hiler wrote: > Hey all, > > Since not so long ago our CI is running and reporting sparse and > checkpatch. Sparse is doing just fine but I had to disable checkpatch > for the time being - too much "false" positives causing people to > complain. I

Re: [PULL] drm-misc-next

2018-03-05 Thread Daniel Vetter
On Fri, Mar 02, 2018 at 04:22:15PM -0500, Sean Paul wrote: > On Wed, Feb 28, 2018 at 3:34 PM, Sean Paul wrote: > > > > Hi Dave, > > Here's this weeks pull, relatively small when you pull out the trivial > > fixes. > > > > drm-misc-next-2018-02-28: > > drm-misc-next for 4.17: > > > > UAPI Changes: