Re: [Discuss] php dev's code with warnings and notices

2014-07-28 Thread Rich Braun
Peter (peabo) Olson pe...@peabo.com asked: What is a static-analysis gate? (Routine search revealed nothing.) Static analysis: http://en.wikipedia.org/wiki/Static_program_analysis That's a step in the build pipeline where your code-base is evaluated for syntax and coding-standards compliance

Re: [Discuss] php dev's code with warnings and notices

2014-07-28 Thread Peter (peabo) Olson
On July 28, 2014 at 1:57 PM Rich Braun ri...@pioneer.ci.net wrote: Peter (peabo) Olson pe...@peabo.com asked: What is a static-analysis gate? (Routine search revealed nothing.) Quality gate: http://en.wikipedia.org/wiki/Quality_gate That's a step in the continuous-integration process

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Eric Chadbourne
On 07/26/2014 08:11 PM, ma...@mohawksoft.com wrote: A properly configured and developed web site with no warning would probably only serve static web pages. Really? I've written code that produces no warnings or notices and I don't consider myself particularly exceptional at programming. I've

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Daniel Barrett
Another reason to track down log messages is performance. I've seen PHP code that inadvertently logged a message on each iteration of a loop. When we removed the message, the web site performance *doubled* (i.e., page render time dropped by half). -- Dan Barrett dbarr...@blazemonger.com

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Eric Chadbourne
On 07/27/2014 12:22 PM, Daniel Barrett wrote: Another reason to track down log messages is performance. I've seen PHP code that inadvertently logged a message on each iteration of a loop. When we removed the message, the web site performance *doubled* (i.e., page render time dropped by half).

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Rich Braun
Eric Chadbourne asked: The code they have submitted works, but it has a bunch of warnings and notices in the logs. I personally think this is sloppy coding. My question is, how strong a stand should I take on this issue? I have the senior role but I am also the new guy. I've recruited a

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Tom Metro
Eric Chadbourne wrote: The code they have...has a bunch of warnings and notices in the logs. I personally think this is sloppy coding. My question is, how strong a stand should I take on this issue? Part of this is going to depend on how practical it is to achieve no warnings in PHP code. I

Re: [Discuss] php dev's code with warnings and notices

2014-07-27 Thread Peter (peabo) Olson
On July 27, 2014 at 2:26 PM Rich Braun ri...@pioneer.ci.net wrote: Eric Chadbourne asked: The code they have submitted works, but it has a bunch of warnings and notices in the logs. I personally think this is sloppy coding. My question is, how strong a stand should I take on this issue?

[Discuss] php dev's code with warnings and notices

2014-07-26 Thread Eric Chadbourne
Hi All, I've recently been asked to work with a team of PHP developers on a pretty large and complex project. The code they have submitted works, but it has a bunch of warnings and notices in the logs. I personally think this is sloppy coding. My question is, how strong a stand should I

Re: [Discuss] php dev's code with warnings and notices

2014-07-26 Thread Bill Horne
On 7/26/2014 5:56 PM, Eric Chadbourne wrote: Hi All, I've recently been asked to work with a team of PHP developers on a pretty large and complex project. The code they have submitted works, but it has a bunch of warnings and notices in the logs. I personally think this is sloppy coding.

Re: [Discuss] php dev's code with warnings and notices

2014-07-26 Thread John Abreau
I've had too many experiences where some sloppy coder was flooding the logs with pointless warnings to the point that the logs were useless for diagnosing actual problems. The clues I needed in order to diagnose a real problem were lost in all the noise. Sloppy coding has a high maintenance cost,

Re: [Discuss] php dev's code with warnings and notices

2014-07-26 Thread markw
Web development is a ghetto or even, still, the wild wild west. A properly configured and developed web site with no warning would probably only serve static web pages. If you log nothing, you miss important errors and warnings, if you log more, you will get stupid errors and warnings. The real