RE: Please Don't Eat Exceptions

2007-06-03 Thread Jerome Louvel
). I hope this will satisfy you. Otherwise, let us know or reopen the bug report. Best regards, Jerome -Message d'origine- De : Adam Taft [mailto:[EMAIL PROTECTED] Envoyé : dimanche 3 juin 2007 04:10 À : discuss@restlet.tigris.org Objet : Re: Please Don't Eat Exceptions Jerome

Re: Please Don't Eat Exceptions

2007-06-03 Thread Adam Taft
[mailto:[EMAIL PROTECTED] Envoyé : vendredi 1 juin 2007 06:05 À : discuss@restlet.tigris.org Objet : Re: Please Don't Eat Exceptions I don't necessarily understand where the first stage and the second stage are in the code you're referring to. So, I can't guess as to whether it's a good solution

RE: Please Don't Eat Exceptions

2007-06-02 Thread Jerome Louvel
06:05 À : discuss@restlet.tigris.org Objet : Re: Please Don't Eat Exceptions I don't necessarily understand where the first stage and the second stage are in the code you're referring to. So, I can't guess as to whether it's a good solution. Maybe think about a lower level

Re: Please Don't Eat Exceptions

2007-05-31 Thread Stian Soiland
On 30 May 2007, at 22:56, Jim Alateras wrote: I'm fine with the design choice. I stumbled across a place where this wasn't happening [1] but it was hard to associate a HTTP status code with the failure since the request failed to leave the client. Currently I have patched it to set the

Re: Please Don't Eat Exceptions

2007-05-31 Thread Thierry Boileau
Hello, we had a discussion with Jerome, and we plainly agree with the fact there is a problem in HttpClientHelper#handle [1] method as pointed out thanksfully by Adam and Jim. This method first builds a call object then sends this call and gets the server's response. The try/catch block is

Re: Please Don't Eat Exceptions

2007-05-31 Thread Jim Alateras
works for me. Will you create an issue for this. cheers /jima Thierry Boileau wrote: Hello, we had a discussion with Jerome, and we plainly agree with the fact there is a problem in HttpClientHelper#handle [1] method as pointed out thanksfully by Adam and Jim. This method first builds a call

Re: Please Don't Eat Exceptions

2007-05-31 Thread Adam Taft
I don't necessarily understand where the first stage and the second stage are in the code you're referring to. So, I can't guess as to whether it's a good solution. Maybe think about a lower level functional class (ie. basically what is Client right now) throwing checked exceptions out of

Re: Please Don't Eat Exceptions

2007-05-30 Thread Jim Alateras
Thierry, I'm fine with the design choice. I stumbled across a place where this wasn't happening [1] but it was hard to associate a HTTP status code with the failure since the request failed to leave the client. Currently I have patched it to set the following status code

Re: Please Don't Eat Exceptions

2007-05-28 Thread Jim Alateras
Adam, I came across the same problem and I believe the problem is more around not setting the response status code on failure. cheers /jima Adam Taft wrote: Here's a test case to look at... public class TestClass { public static void main(String[] args) { try {

Please Don't Eat Exceptions

2007-05-23 Thread Adam Taft
Here's a test case to look at... public class TestClass { public static void main(String[] args) { try { Request request = new Request(Method.GET, a); Client client = new