RE: XmlRepresentation.internalEval

2008-10-17 Thread Jerome Louvel
11:29 À : discuss@restlet.tigris.org Objet : Re: XmlRepresentation.internalEval I don't suppose we have any Eclipse developers on the list taking notes? On Wed, Oct 15, 2008 at 3:26 AM, Richard Hoberman <[EMAIL PROTECTED]> wrote: Tim Peierls wrote: > It's not a huge deal, bu

Re: XmlRepresentation.internalEval

2008-10-15 Thread Rob Heittman
I don't suppose we have any Eclipse developers on the list taking notes? On Wed, Oct 15, 2008 at 3:26 AM, Richard Hoberman < [EMAIL PROTECTED]> wrote: > Tim Peierls wrote: > > It's not a huge deal, but superfluous final keywords are clutter that > > distract from the places where final is being u

Re: XmlRepresentation.internalEval

2008-10-15 Thread Richard Hoberman
Tim Peierls wrote: > It's not a huge deal, but superfluous final keywords are clutter that > distract from the places where final is being used meaningfully. I > think it's worth cleaning this up incrementally in Restlet. This would do it: perl -pie 's/final (?=[a-zA-Z]*Exception)//g' `find . -na

Re: XmlRepresentation.internalEval

2008-10-14 Thread Tim Peierls
It's not a huge deal, but superfluous final keywords are clutter that distract from the places where final is being used meaningfully. I think it's worth cleaning this up incrementally in Restlet. --tim On Tue, Oct 14, 2008 at 4:28 PM, Rob Heittman <[EMAIL PROTECTED]>wrote: > A bit of troglodyti

Re: XmlRepresentation.internalEval

2008-10-14 Thread Rob Heittman
A bit of troglodytic practicality: I can easily tell Eclipse to stick "final" wherever it possibly can, but not (to my knowledge) selectively omit cases like catch blocks. So it makes code that looks like this. I agree it's kind of dumb here, specifically, but the general practice of allowing Ecl

Re: XmlRepresentation.internalEval

2008-10-14 Thread Richard Hoberman
I'm doing some reading and have found the following links useful: 1. Link to a free chapter on the final keyword in Robert Simmons 'Hardcore Java' (O'Reilly) together with a useful summary. http://hoskinator.blogspot.com/2006/04/hardcore-java-final-story.html 2. Brian Goetz comments on the 'fina

Re: XmlRepresentation.internalEval

2008-10-14 Thread Tim Peierls
-- > *De :* [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] *De la part de* Tim > Peierls > *Envoyé :* mardi 14 octobre 2008 21:06 > *À :* discuss@restlet.tigris.org > *Cc :* Jerome Louvel > *Objet :* Re: XmlRepresentation.internalEval > > On Tue, Oct 14, 200

RE: XmlRepresentation.internalEval

2008-10-14 Thread Jerome Louvel
: Jerome Louvel Objet : Re: XmlRepresentation.internalEval On Tue, Oct 14, 2008 at 2:41 PM, Jerome Louvel <[EMAIL PROTECTED]> wrote: For the 'final' keyword usage, it might save a bit of memory at most. No big gain here I suspect. How would memory be saved? Are there really compilers

Re: XmlRepresentation.internalEval

2008-10-14 Thread Tim Peierls
On Tue, Oct 14, 2008 at 2:41 PM, Jerome Louvel <[EMAIL PROTECTED]>wrote: > For the 'final' keyword usage, it might save a bit of memory at most. No > big gain here I suspect. How would memory be saved? Are there really compilers that generate different bytecode depending on the presence of the f

RE: XmlRepresentation.internalEval

2008-10-14 Thread Jerome Louvel
-Message d'origine- De : Richard Hoberman [mailto:[EMAIL PROTECTED] Envoyé : lundi 13 octobre 2008 12:18 À : discuss@restlet.tigris.org Objet : XmlRepresentation.internalEval Hi Here is a snippet of code from a failing test case: 1 DomRepresentation results = response.getEntityAsDom

RE: XmlRepresentation.internalEval

2008-10-14 Thread Jerome Louvel
t most. No big gain here I suspect. Best regards, Jerome -Message d'origine- De : Jerome Louvel Envoyé : mardi 14 octobre 2008 20:37 À : discuss@restlet.tigris.org Objet : RE: XmlRepresentation.internalEval Hi Richard, Thanks for the report. Your suggestion makes sense, so now

XmlRepresentation.internalEval

2008-10-13 Thread Richard Hoberman
Hi Here is a snippet of code from a failing test case: 1 DomRepresentation results = response.getEntityAsDom(); 2 System.out.println(response.getEntityAsForm()); // temporary output while writing test 3 NodeSet nodes = results.getNodes("/a/b/c"); 4 Assert.assertNotNull(nodes); // fails