Re: [Discuss-gnuradio] gri_ringbuffer.{h,cc}

2006-03-13 Thread Eric Blossom
On Sun, Mar 12, 2006 at 10:20:16PM +0100, Stephane Fillod wrote: > > - against gnuradio-core: ot_gri_ringbuffer.patch > * src/lib/general/gri_ringbuffer.{cc,h}, > src/lib/general/Makefile.am: new lockless ringbuffer (single > reader/single writer) taken from JACK software (

Re: [Discuss-gnuradio] gri_ringbuffer.{h,cc}

2006-03-12 Thread Stephane Fillod
On Sun, Mar 12, 2006 at 06:03:39PM -0800, Eric Blossom wrote: > On Sun, Mar 12, 2006 at 10:20:16PM +0100, Stephane Fillod wrote: > > > > - against gnuradio-core: ot_gri_ringbuffer.patch > > * src/lib/general/gri_ringbuffer.{cc,h}, > > src/lib/general/Makefile.am: new lockless ringbuffer

Re: [Discuss-gnuradio] gri_ringbuffer.{h,cc}

2006-03-12 Thread Robert McGwier
Frank Brickle wrote: Robert McGwier wrote: There are subtle race conditions that might occur but they are minor irritants compared to the stupidity of what we were doing. In particular you'd want to make sure any values that can be read in the callback are set atomically in the client code.

Re: [Discuss-gnuradio] gri_ringbuffer.{h,cc}

2006-03-12 Thread Frank Brickle
Robert McGwier wrote: There are subtle race conditions that might occur but they are minor irritants compared to the stupidity of what we were doing. In particular you'd want to make sure any values that can be read in the callback are set atomically in the client code. That includes flags th

Re: [Discuss-gnuradio] gri_ringbuffer.{h,cc}

2006-03-12 Thread Robert McGwier
No. The problem was caused by our own error. Under some pathological conditions you want to reset the ring buffers and start over. We talked ourselves into believing all off this was protected and we were just plain wrong. I made the initial error and Frank recaptured the error in beautiful