Re: [Distutils] Commit 17f89f4 "Update sdist to use sdist_add_defaults forward compatibility"

2016-10-22 Thread Brandon Casey
Hey Jason, Thanks for the quick reply. I wasn't able to get around to doing it this past weekend. I'll try to take a look this weekend. -Brandon On Sat, Oct 15, 2016 at 11:50 AM, Jason R. Coombs wrote: > The discussion started here: https://github.com/pypa/setuptools/pull/750 > > Basically, I

[Distutils] Commit 17f89f4 "Update sdist to use sdist_add_defaults forward compatibility"

2016-10-15 Thread Brandon Casey
Hi Jason, I just started looking at the setuptools repo last night to see if I could figure out why setuptools doesn't place data_files inside an sdist and I saw your commit 17f89f4 to teach the sdist command to use the python 36 compatibility behavior. But it overrides _add_defaults_data_files()

Re: [Distutils] Commit 17f89f4 "Update sdist to use sdist_add_defaults forward compatibility"

2016-10-15 Thread Jason R. Coombs
The discussion started here: https://github.com/pypa/setuptools/pull/750 Basically, I don’t understand exactly why that functionality was disabled, but I give my best guess in that ticket - mainly that I think data_files is incompatible with encapsulated installs, so I suspect it was explicitly,