I have some feedback on PEP376, both the pep itself and the pkgutil
code. I'll start with comments on the PEP.
* I don't like the definition of a project: this seems to define what
distutils calls a distribution, and that is not necessarily and
application.
* The description of the status
2009/6/7 Ronald Oussoren :
> I have some feedback on PEP376, both the pep itself and the pkgutil code.
> I'll start with comments on the PEP.
Thanks for this detailed feedback.
>
> * I don't like the definition of a project: this seems to define what
> distutils calls a distribution, and that i
On 8 Jun, 2009, at 2:58, Tarek Ziadé wrote:
2009/6/7 Ronald Oussoren :
* The global functions seem to maintain and modify global state,
wouldn't this cause problems if I specify different values of the
path arguments in different pieces of code?
The cache just prevents re-reading a dir
2009/6/8 Ronald Oussoren :
> I guess the problem only occurs if "egg_infos" is part of the public
> interface. What if module A calls get_egg_infos(), then module B calls
> get_egg_infos(somePath), then module A uses "egg_infos" assuming that it
> still refers to the same set of paths.
Vaguely off
On Mon, Jun 8, 2009 at 5:11 PM, Paul Moore wrote:
> 2009/6/8 Ronald Oussoren :
>> I guess the problem only occurs if "egg_infos" is part of the public
>> interface. What if module A calls get_egg_infos(), then module B calls
>> get_egg_infos(somePath), then module A uses "egg_infos" assuming that i
On 8 Jun, 2009, at 8:16, Tarek Ziadé wrote:
On Mon, Jun 8, 2009 at 5:11 PM, Paul Moore wrote:
2009/6/8 Ronald Oussoren :
I guess the problem only occurs if "egg_infos" is part of the public
interface. What if module A calls get_egg_infos(), then module B
calls
get_egg_infos(somePath), then
On Mon, Jun 8, 2009 at 5:23 PM, Ronald Oussoren wrote:
>
> On 8 Jun, 2009, at 8:16, Tarek Ziadé wrote:
>
>> On Mon, Jun 8, 2009 at 5:11 PM, Paul Moore wrote:
>>>
>>> 2009/6/8 Ronald Oussoren :
I guess the problem only occurs if "egg_infos" is part of the public
interface. What if mod
2009/6/8 Tarek Ziadé :
> Mmm, that's my frenglish, Sir ;) (If you see other weird stuff
> please let me know)
Well, it's better than my French, so who am I to complain? (As
everyone knows, the English speak French by USING ENGLISH WORDS, BUT
SHOUTING... :-))
> So I guess "get_egg_info" is the
On Mon, Jun 8, 2009 at 3:04 PM, Ronald Oussoren wrote:
>
> On 8 Jun, 2009, at 2:58, Tarek Ziadé wrote:
>
>> 2009/6/7 Ronald Oussoren :
>>
>>>
>>> * The global functions seem to maintain and modify global state, wouldn't
>>> this cause problems if I specify different values of the path arguments in
On 09-06-08 02:58 AM, Tarek Ziadé wrote:
>
> * Should the PEP specify the encoding of text-files? PEP314 doesn't seem to
specify the encoding of PKG-INFO files, which can cause problems when a field
contains data that isn't ASCII.
The encoding used is utf-8 since 2.6. I think we should rath
On 8 Jun, 2009, at 10:36, Sridhar Ratnakumar wrote:
On 09-06-08 02:58 AM, Tarek Ziadé wrote:
>
> * Should the PEP specify the encoding of text-files? PEP314
doesn't seem to specify the encoding of PKG-INFO files, which can
cause problems when a field contains data that isn't ASCII.
The
2009/6/8 Paul Moore :
> That's the place I mean. But I'm not sure I like the idea of calling
> it an "EggInfo". I'll see if I can think of a better name (but not
> being familiar with the domain, I'm not sure I'll be able to).
Hmm.
Reading the PEP, the EggInfo class represents the contents of the
At 04:35 PM 6/8/2009 +0100, Paul Moore wrote:
2009/6/8 Ronald Oussoren :
> The thingy we're getting is called an "EggInfo", which would IMHO mean that
> "get_egg_infos" is technically the correct name for something
that returns a
> list of them. I'd interpret the singular form as a function that
Glancing over the EggInfo, EggInfoDirectories, and EggInfoDirectory
APIs, it might be interesting if these were able to match with the PEP
3119 interfaces (http://www.python.org/dev/peps/pep-3119/).
For example, the EggInfoDirectories has __iter__, append, clear and
remove methods, but the source
On 09-06-08 01:48 PM, Ronald Oussoren wrote:
On 8 Jun, 2009, at 10:36, Sridhar Ratnakumar wrote:
On 09-06-08 02:58 AM, Tarek Ziadé wrote:
>
> * Should the PEP specify the encoding of text-files? PEP314
doesn't seem to specify the encoding of PKG-INFO files, which can
cause problems when a fi
Ronald Oussoren writes:
> On 8 Jun, 2009, at 8:16, Tarek Ziadé wrote:
>
> > On Mon, Jun 8, 2009 at 5:11 PM, Paul Moore wrote:
> >> Vaguely off-topic, but is it only me that hates the abbreviation
> >> "infos"? It can only realistically be an abbreviation for the word
> >> "informations" - and th
On Tue, Jun 9, 2009 at 12:18 AM, Sridhar
Ratnakumar wrote:
>
>> My best guess is that it doesn't use any encoding, it just
>> dumps the bytes in the string you specified in the PKG-INFO file (at
>> least for python2, I haven't checked what distutils does in python3).
>
> Correct; that is what I tho
17 matches
Mail list logo
