Re: Code review checklist

2016-10-30 Thread John-Scott
ting/code.html > > any other opinion? > > Cheers > Angelo > > On Saturday, 22 October 2016 06:08:08 UTC+2, John-Scott wrote: >> >> Is there any sort of code review checklist used internally by the core >> developers? Something that could be referenced by rev

Re: Code review checklist

2016-10-23 Thread Angelo Dini
tober 2016 06:08:08 UTC+2, John-Scott wrote: > > Is there any sort of code review checklist used internally by the core > developers? Something that could be referenced by reviewers before > approving changes, e.g. 'If this change modifies a public API call > signature, be sur

Code review checklist

2016-10-21 Thread John-Scott
Is there any sort of code review checklist used internally by the core developers? Something that could be referenced by reviewers before approving changes, e.g. 'If this change modifies a public API call signature, be sure to clearly document the impact/follow the deprecation polic