Extra params + aggregation creates incorrect SQL - Ticket 11916 - Oracle issues

2010-03-20 Thread Tobias McNulty
I just created a test for http://code.djangoproject.com/ticket/11916 The test verifies that the code fix makes the query succeed on mysql, pgsql, and sqlite. On oracle, however, not only does the new test fail, but the code fix also breaks other tests in aggregation_regress (thanks kmt for testin

Re: media in ModelAdmin

2010-03-20 Thread Luca Sbardella
Now I know the best practice. I leave it as it is. Thanks On 20 Mar, 11:49, Russell Keith-Magee wrote: > On Sat, Mar 20, 2010 at 6:43 PM, Simon Meers wrote: > >> As documented here [1], the ticket is closed when the code is > > >> committed to SVN. If you think you've met all the requirements fo

Re: media in ModelAdmin

2010-03-20 Thread Russell Keith-Magee
On Sat, Mar 20, 2010 at 6:43 PM, Simon Meers wrote: >> As documented here [1], the ticket is closed when the code is >> >> committed to SVN. If you think you've met all the requirements for the >> code to be committed to trunk, you can mark a ticket >> ready-for-checkin. >> >> [1] http://docs.djan

Re: Templates by app

2010-03-20 Thread reg_gc
You can use both schemes. > Is there any reason to have a global directory with all templates > instead of to have the templates for each application: > > project/ > \___ apps/ > \___ templates/ > -- You received this message because you are subscribed to the Google Groups "Django devel

Re: Templates by app

2010-03-20 Thread Gert Van Gool
django-developers is for the discussion of the development of Django itself, not development with Django. As such this mailing list is not appropriate for this message, django-users would be more appropriate. But to quickly answer, yes. Especially if you're using many 3rd party apps. -- Gert Mob

Templates by app

2010-03-20 Thread Joan Miller
Is there any reason to have a global directory with all templates instead of to have the templates for each application: project/ \___ apps/ \___ templates/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send

Re: media in ModelAdmin

2010-03-20 Thread Simon Meers
> > As documented here [1], the ticket is closed when the code is > committed to SVN. If you think you've met all the requirements for the > code to be committed to trunk, you can mark a ticket > ready-for-checkin. > > [1] http://docs.djangoproject.com/en/1.1/internals/contributing/ > > The way I

Re: media in ModelAdmin

2010-03-20 Thread Russell Keith-Magee
On Sat, Mar 20, 2010 at 6:06 PM, Luca Sbardella wrote: > Hi Russell, > I made a couple of changes to forms.widgets in relation to your > comments. > Tests passed. Shall I close the ticket? (not sure about best practice) No. As documented here [1], the ticket is closed when the code is committed

Re: media in ModelAdmin

2010-03-20 Thread Luca Sbardella
Hi Russell, I made a couple of changes to forms.widgets in relation to your comments. Tests passed. Shall I close the ticket? (not sure about best practice) Thanks Luca On 19 Mar, 00:55, Russell Keith-Magee wrote: > On Thu, Mar 18, 2010 at 9:57 PM, Luca Sbardella > > > > > > wrote: > > Currently