Re: #3011 - Custom User Models -- Call for final review

2012-09-16 Thread Russell Keith-Magee
Hi all, I've just pushed fixes that: * Correct the patch for Python 3 * Merges Anssi's AbstractUser base class changes * Moves skipIfCustomUser to django.contrib.auth.tests.utils * Improves the error message when you have a Proxy to a swapped class * Updates the documentation to address the

Re: #3011 - Custom User Models -- Call for final review

2012-09-16 Thread Anssi Kääriäinen
On 16 syys, 02:15, Russell Keith-Magee wrote: > >   - The last_login field is in the AbstractBaseUser, but it isn't > > documented as a required field. Is this field required for something? > > Is it needed as part of AbstractBaseUser? > > Yes, last_login is required - it's needed in order to gene

Re: #3011 - Custom User Models -- Call for final review

2012-09-16 Thread Russell Keith-Magee
On Sun, Sep 16, 2012 at 8:15 PM, Anssi Kääriäinen wrote: > On 16 syys, 02:15, Russell Keith-Magee > wrote: > Creating an admin class for no-added-fields extended user model is > somewhat straightforward, although the admin forms currently assume > the auth.User as the base user. I did a little ha

Re: #3011 - Custom User Models -- Call for final review

2012-09-16 Thread Anssi Kääriäinen
On 16 syys, 15:50, Russell Keith-Magee wrote: > We could easily hold up this patch on making the admin forms > completely flexible for all possible user models. However, for my > money, we still have a couple of months to nail down any problem areas > in the API, and we'll get more benefit from ha

Re: #3011 - Custom User Models -- Call for final review

2012-09-16 Thread Karen Tracey
On Sun, Sep 16, 2012 at 9:13 AM, Anssi Kääriäinen wrote: > I meant to say that after this is committed to 1.5, should we allow for > some polishing changes to get in after feature freeze even if they are > technically feature additions. > The kinds of changes you are describing can, I believe, be

Re: end of "coming soon" in the tutorial? - tutorial 5 feedback needed!

2012-09-16 Thread Tim Graham
https://code.djangoproject.com/ticket/16671 On Saturday, September 15, 2012 7:24:23 PM UTC-4, Tim Graham wrote: > > Katie Miller and Ben Sturmfels have written a fifth tutorial covering > making "polls" a reusable app. I've given it an initial review, but I'm > hoping we can get a few more peop

Re: Testing django 1.5 with firebirdsql

2012-09-16 Thread charettes
Here's the topic you were referring to Anssi. https://groups.google.com/forum/#!topic/django-developers/AZrSn6LCLVU/discussion Le samedi 15 septembre 2012 13:18:38 UTC-4, Anssi Kääriäinen a écrit : > > On 15 syys, 01:05, maxi wrote: > > BTW, I've another issue related to one specific test. > >