Re: Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-05 Thread Shai Berger
Hi again Malcolm, I think making assertions in the test client is wrong for most situations, though I can't (of course) say much about your specific case; so I'm -1 on adding the testcase as a client initializer argument (this would send the message that such things are encouraged). However, n

Re: Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-05 Thread Malcolm Box
On Sat, Jan 5, 2013 at 9:11 AM, Shai Berger wrote: > On Friday 04 January 2013, Malcolm Box wrote: > > > > The general pattern I want to implement is have a test client that makes > > assertions about all the requests made during a set of tests. For > example, > > it could check that every get()

Re: Minor feature: Make TestCase pass the testcase instance to self.client's constructor

2013-01-05 Thread Shai Berger
On Friday 04 January 2013, Malcolm Box wrote: > > The general pattern I want to implement is have a test client that makes > assertions about all the requests made during a set of tests. For example, > it could check that every get() returned cache headers, or that > content_type is always specifi