test_disable_constraint_checks_context_manager

2014-02-02 Thread Wlodek
Hi all, I have doubt about mentioned test. Is it correct? As context manager "constraint_checks_disabled" enables constraint checking upon exit which is before end of transaction (rollback) there will/should be IntegrityError raised? As I understand this test passes for oracle/postgres because

Re: Ticket #21751 review requested

2014-02-02 Thread Michael Manfre
The pull request has been rebased. Thanks, Michael Manfre On Sun, Feb 2, 2014 at 9:40 AM, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hi Michael, > > On 21 janv. 2014, at 19:05, Michael Manfre wrote: > > The overall feedback I've gotten from my pull request seems positive.

Re: Ticket #21751 review requested

2014-02-02 Thread Aymeric Augustin
Hi Michael, On 21 janv. 2014, at 19:05, Michael Manfre wrote: > The overall feedback I've gotten from my pull request seems positive. I'll > rebase it against master and submit it for merging. Let me know when you do this. I'll push the merge button before the patch gets out of date :-) Thank

Re: Minor concern with the "apps" convention

2014-02-02 Thread Aymeric Augustin
On 27 janv. 2014, at 01:40, Russell Keith-Magee wrote: > It's worth documenting this as a gotcha in the app loading docs (with the > admonition of "this is why you don't put code in __init__.py"), but I don't > think we need to be overly concerned. Done: https://github.com/django/django/commi