Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Chris Foresman
On Tuesday, April 18, 2017 at 1:25:36 PM UTC-5, Tim Allen wrote: > > Thanks for the kind words. To answer your questions: > > - It is also my hope to automagically create version friendly links, so we > don't see a commit on each Django release. > This ought to be useful to sub in where necessa

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Collin Anderson
I was also reminded of green color the green color discussion. >From the discussion about the admin redesign [0][1]: "makes keeping a visual identity for Django hard to separate from the admin UI" "the admin is part of _your_ site, not ours, and so should have a visually-distinct theme/brand that

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Ryan Hiebert
On Tue, Apr 18, 2017 at 11:27 AM Daniele Procida wrote: > On Tue, Apr 18, 2017, Tim Allen wrote: > > >It struck me that this page is valuable real estate > > Yes it is! Firstly, I think that both your idea and design are excellent > and I approve. > > Secondly, since that space is valuable, perh

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Tim Allen
Your point on design by committee is spot-on; I think that's the direction we'll head in. Thanks for the kind words, and I've noted the issues on the smaller height and smaller screen issues. It is much apprecaited! Regards, Tim On Tuesday, April 18, 2017 at 1:30:23 PM UTC-4, Aymeric Augustin

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Tim Allen
Thanks for the kind words. To answer your questions: - My colleague Chad did the rocket animation. We'll both do git signed commits on any pull request and add ourselves to authors. - It is also my hope to automagically create version friendly links, so we don't see a commit on each Django relea

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Aymeric Augustin
Hello Tim, Thanks, that's a great initiative! Given the well-documented success rate of design by committee, including our experience redesigning djangoproject.com, there's a risk that an inconclusive discussion on this mailing list will prevent your proposal from moving forwards. Perhaps a go

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Daniele Procida
On Tue, Apr 18, 2017, Tim Allen wrote: >It struck me that this page is valuable real estate Yes it is! Firstly, I think that both your idea and design are excellent and I approve. Secondly, since that space is valuable, perhaps it could also say: This release of Django has been sponsored

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Collin Anderson
Beautiful. The Google Font should not be an issue. We're already distributing that as part of the admin, which is installed by default. The page could just reference /static/admin/css/fonts.css. Does a license need to be included for the rocket animation, or is that your own work? I hope the lin

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Tim Allen
Switching to another font is certainly an option. Is the issue with Google Fonts the Apache license versus the Django BSD license? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this g

Re: A New Design for the "Congratulations!" Page

2017-04-18 Thread Tom Forbes
I'm not a core developer but I'd just like to say that your redesign looks amazing and is a big improvement. Even if this specific design is not acceptable I think it's a great idea to link to the tutorials/documentation from that page. I'm not a big fan of it loading the fonts from Google Fonts h

A New Design for the "Congratulations!" Page

2017-04-18 Thread Tim Allen
I've had the privilege of introducing Django to many people over the past several years. A recurring theme I have noticed is that once a new Django developer reaches the "It Worked!" page, the inevitable next question is, "now what?" It struck me that this page is valuable real estate for the newc

Error while doing migrations for a new table

2017-04-18 Thread Mohamed Ghariani
Hello, I tried to apply migrations for a new model. The model was used in a form used in the admin so the migrations failed. He is a sample code i wrote which gave me the same errors. models.py from django.db import models class App(models.Model): name = models.CharField(max_length=50) fo

[Feature Request] In admin the variable has_change_permission in change_form.html should not be used for the breadcrumb menu

2017-04-18 Thread Contributions to Django itself
In admin when rendering a change form the breadcrumb menu includes a link to the changelist, or only a text. The template’s variable has_change_permission is used to decide which to show. As far as I understand the variable is set in ModelAdmin to has_change_permissions(request, obj) by defaul