Re: Explore integrating django-docker-box in some way?

2018-12-04 Thread Tom Forbes
To have this completely working at sprints without having everyone building their own local images we would need to have the Jenkins server use docker in some capacity. This would also require an official django account on Docker hub. The pattern I’m using right now is that on every build we pull

Re: Explore integrating django-docker-box in some way?

2018-12-04 Thread Josh Smeaton
Size of the image could definitely be a concern, especially at sprints where wifi speeds aren't always optimal. The django-box image is significantly larger though so it'd still be a net win. There are also optimisations that can be made to the image for reducing size over time, so I'd fully

Re: Explore integrating django-docker-box in some way?

2018-12-04 Thread Tom Forbes
Thank you for the reply Josh. I didn’t anticipate any suggestions for including this inside core but off the back of your suggestion I’ve made a ticket here: https://code.djangoproject.com/ticket/30010. I don’t think it should be complex at all to include this inside Django - it’s four or five

Re: Allow usage of widgets in generic class-based views?

2018-12-04 Thread charettes
I agree with Tim that this is a slippery slope. Maybe that adding a ModelFormMixin.get_form_class_options() that returns a {'fields': self.fields} dict by default and is passed to modelform_factory(**kwargs) in get_form_class() would be a good compromise? Best, Simon Le mardi 4 décembre 2018

Re: Allow usage of widgets in generic class-based views?

2018-12-04 Thread Tim Graham
What I meant is that modelform_factory() also has these parameters: localized_fields is a list of names of fields which should be localized. labels is a dictionary of model field names mapped to a label. help_texts is a dictionary of model field names mapped to a help text. error_messages is a

Allow usage of widgets in generic class-based views?

2018-12-04 Thread Dan F
https://code.djangoproject.com/ticket/24589 This ticket has a patch to pass through the "widgets" argument for generic class-based views. It was closed with "won't fix" with this comment: "*I don't think the possibility of saving a few lines of user code justifies the complexity of

Re: Fellow Reports -- November 2018

2018-12-04 Thread Carlton Gibson
Hi all, Calendar Week 47 -- ending 25 November. Triaged: https://code.djangoproject.com/ticket/29979 -- Refactor AutoField logic into a mixin, implement checks and validators. (Accepted) https://code.djangoproject.com/ticket/29976 -- How to perform Group by on Union of two models (invalid)