Re: collectstatic command should output minified files

2020-12-21 Thread Arvind Nedumaran
I kinda like the idea of being able to run collectstatic and not have to worry about setting up a full on frontend workflow for pretty much just minification. It is a great default to have when this is all you need. That said, I’d be more interested in seeing something like an official or a dj

collectstatic command should output minified files

2020-12-21 Thread Diptesh Choudhuri
The default files copied to STATIC_ROOT when you run python manage.py collectstatic should have two versions- file.js and file.min.js (similarly for css files). As far as I can see, this happens only for the preinstalled apps (like admin/actions.min.js) but not for user installed apps. Serbing m

Re: Multi theme support for admin

2020-12-21 Thread Adam Johnson
Ramez - one can switch themes on a per-site basis already by overriding AdminSite.each_context() to add style control variables, and overriding the "admin/base_site.html" template (and other templates) to conditionally include different CSS or elements. I know that such a solution is unlikely to al

Re: Multi theme support for admin

2020-12-21 Thread Matthias Kestenholz
Hey, I'm still working on https://github.com/django/django/pull/13435 , an attempt to use CSS variables to style the administration interface. Unfortunately, real life and (desired) deadlines from paid projects tend to interfere. I still very much intend to clean up the pull request which is getti

Multi theme support for admin

2020-12-21 Thread Ramez Ashraf
Hello Django Developers list I'm sending on this thread to hopefully open a discussion about *Adding the ability for a multi custom theme in Django's Admin*. *What do i mean ?* We can have many multiple Django admin sites

Re: Query identity operation

2020-12-21 Thread Adam Johnson
1. Sure, pushed a commit 2. Tests: https://github.com/adamchainz/django/blob/72ce349bb283910b8c4d6a6e0f2250055b5bffb5/tests/queries/test_q.py#L6-L9 Please leave PR-specific feedback on GitHub in future :) On Mon, 21 Dec 2020 at 15:29, Ken Whitesell wrote: > A couple questions came to mind if we

Re: Query identity operation

2020-12-21 Thread Ken Whitesell
A couple questions came to mind if we're going to document this as "official behavior": 1. This also appears to be true for filter. Would the same clarification be appropriate there? 2. I don't see any tests validating the behavior for either Q or filter, should there be? Ken On 12/21/20

Re: Query identity operation

2020-12-21 Thread Adam Johnson
I saw that Q() with no arguments is not documented, so I've made a PR to add a sentence covering it: https://github.com/django/django/pull/13798 . On Mon, 21 Dec 2020 at 05:21, Mariusz Felisiak wrote: > > complete_query = ~Q(pk__in=[]) # this should be something like Q.ident() >> > > You can us

Re: Fellow Reports - December 2020

2020-12-21 Thread Mariusz Felisiak
Week ending December 20, 2020. *Triaged: * https://code.djangoproject.com/ticket/32263 - squashmigrations produces incorrect result with a RenameModel on a ForeignKey target. (accepted) https://code.djangoproject.com/ticket/32265 - Remove unnecessary ServerHandler.handle_error(). (created