Re: Transaction APIs do not consult the DB router to choose DB connection

2021-05-31 Thread N Aditya
Hey Adam/Simon, How can we take this forward ? Regards, Aditya N On Friday, May 28, 2021 at 3:04:14 PM UTC+5:30 N Aditya wrote: > Hey Adam, > > Also, after giving it a bit of thought, I figured that integrating this > logic with the routers framework isn't entirely necessary. > So I came u

Re: Transaction APIs do not consult the DB router to choose DB connection

2021-05-31 Thread charettes
Aditya, > "atomic does already call DB routers" -> Firstly after reading code, I don't think the transaction APIs consult the routers. Secondly, I think I already answered it in the initial discussion. Atomic doesn't consult it directly but the ORM does before interacting with transactions. Wh

Re: Transaction APIs do not consult the DB router to choose DB connection

2021-05-31 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I'm also -1 on changing anything in Django right now. I think we should indeed take the "default position" for complex features: write a third party library, get some traction. If many people find it useful, we can look at adding something to core. It sounds like you're already working on such a l

Re: Fellow Reports - May 2021

2021-05-31 Thread Mariusz Felisiak
Week ending May 30, 2021 *Triaged: * https://code.djangoproject.com/ticket/32774 - cache_page decorator doesn't work for cross-browser (needsinfo) https://code.djangoproject.com/ticket/32778 - Avoided unnecessary recompilation of token regex in _sanitize_token(). (accepted) https://co

Re: Transaction APIs do not consult the DB router to choose DB connection

2021-05-31 Thread Florian Apolloner
On Monday, May 31, 2021 at 12:13:58 PM UTC+2 Adam Johnson wrote: > I'm also -1 on changing anything in Django right now. > -1 as well, I simply see no way how something like: ``` with transaction.atomic(): Model1.objects.create() Model2.objects.create() ``` will allow for any useful