Re: Inconsistent pagination when sorting by non-unique columns (ticket 34251)

2023-01-11 Thread tatari...@gmail.com
Thanks for the input, Barry! To be clear - Django already enforces total ordering in the admin panel by adding "pk" (in this method ), which makes me believe that's a viable approach. Sure, there can be domain-s

Re: Inconsistent pagination when sorting by non-unique columns (ticket 34251)

2023-01-11 Thread 'Barry Johnson' via Django developers (Contributions to Django itself)
I'd be very much -1 if the framework modified my sorting parameters (by adding 'pk' at the end of the ordering). As mentioned, it can certainly break queries that can be handled by a covering index... but mostly because 'pk' isn't the field we would prefer to use in this case anyway. For ex

Inconsistent pagination when sorting by non-unique columns (ticket 34251)

2023-01-11 Thread tatari...@gmail.com
As described in https://code.djangoproject.com/ticket/34251, some database backends (incl. PostgreSQL) will produce non-deterministic ordering when sorting by columns with non-unique values. This leads to inconsistent pagination, which I argue falls under the same category as paginating by unord

Re: Backport for ticket 34063?

2023-01-11 Thread Mariusz Felisiak
Hi, I'm against the backport for the same reasons already mentioned by Carlton. So -1 from me. Best, Mariusz -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop re