Getting full URL using django.urls.base.reverse - PR

2016-11-05 Thread Mislav Cimperšak
During the sprint in Amsterdam I created a pull request https://github.com/django/django/pull/7484 In it I'm adding an optional argument `request` to `django.urls.base.urls.reverse`method. The idea is that using `request` object one can get a fully qualified URL. The idea is taken from Django R

Re: Getting full URL using django.urls.base.reverse - PR

2016-11-05 Thread Mislav Cimperšak
rsonally I would set the > current domain on the local "urlconf" (we have one per thread) and add a > "full" kwarg to reverse (and something similar to the urltag). > > Cheers, > Florian > > On Saturday, November 5, 2016 at 3:41:09 PM UTC+1, Mislav Ci

Re: Getting full URL using django.urls.base.reverse - PR

2016-11-11 Thread Mislav Cimperšak
Thinking about url tag and threadlocals is a step in the wrong direction. The original PR is just a simple addition (that is still backwards compatible) to the `reverse` method; how people choose to use it (and when) is up to them. Adding something to the `url` tag is almost bound to brake somethi

Re: Getting full URL using django.urls.base.reverse - PR

2016-11-11 Thread Mislav Cimperšak
#x27;blog-year', kwargs={'year': 2016}, host=True, scheme='https://') >> -> https://blog.example.com/articles/2016/ >> >> reverse('api:user-list') -> /v1/users/ >> reverse('api:user-list', host=True) -> https://api.examp