Re: Difference between AdminSite.admin_view and staff_member_required?

2021-03-09 Thread Timothy McCurrach
rs@googlegroups.com < > django-developers@googlegroups.com> *On Behalf Of *Timothy McCurrach > *Sent:* Tuesday, March 9, 2021 3:22 PM > *To:* django-developers@googlegroups.com > *Subject:* Re: Difference between AdminSite.admin_view and > staff_member_required? > > >

Re: Difference between AdminSite.admin_view and staff_member_required?

2021-03-09 Thread Timothy McCurrach
staff_member_required feels like a bit of a relic from the past: - It looks like before a massive refactor of the admin that happened 12 years ago ( https://github.com/django/django/commit/a19ed8aea395e8e07164ff7d85bd7dff2f24edca) staff_member_required played a similar role to what Adminsite.admin

Re: To keep or not to keep: logging of undefined template variables

2021-01-24 Thread Timothy McCurrach
I was going to have a go at this ticket (https://code.djangoproject.com/ticket/28526) - which links this thread. Having read the various replies, it seems like there is no shortage of differing views how missing/invalid variables should be treated: - There should be no logging - There should