Re: Binding LiveServerTestCase bind to port 0

2016-06-21 Thread Tim Graham
I'm inclined to make the changes, skip the deprecation, and react appropriately if anyone raises a use case that can't be achieved with the new "bind to port 0" technique. I found a few more things that could be removed, for example the "manage.py test --liveserver=..." option. Only creating a

Re: Binding LiveServerTestCase bind to port 0

2016-06-16 Thread charettes
I've never personally used DJANGO_LIVE_TEST_SERVER_ADDRESS for another purpose than preventing port conflicts which binding to port 0 solves. It always looked strange to me to rely on an environment variable to achieve this. It feels like it was done this way to avoid introducing yet another se

Re: Binding LiveServerTestCase bind to port 0

2016-06-16 Thread Daryl
Wow : +8 −100 for that commit - that's a great re-factoring :) On 17 June 2016 at 13:23, Tim Graham wrote: > In IRC the other day, Donald pointed out > https://www.dnorth.net/2012/03/17/the-port-0-trick/ and suggested that > Django might be able to take advantage of that technique. > > I put tog

Binding LiveServerTestCase bind to port 0

2016-06-16 Thread Tim Graham
In IRC the other day, Donald pointed out https://www.dnorth.net/2012/03/17/the-port-0-trick/ and suggested that Django might be able to take advantage of that technique. I put together a proof of concept that seems to work: https://github.com/django/django/pull/6791 I'm wondering if anyone see