Bugfix on #29103 creates different bug

2019-04-15 Thread Melvyn Sopacua | 3YOURMIND
Hi, I've added a comment on the commit: https://github.com/django/django/commit/3c4ff2176323dd20507e35658599da220fbe1741 Should I reopen the bug or create a new one? Also it would help to know what the return type is supposed to be or what the intention of the code is? Should the if clause be `no

Re: Bugfix on #29103 creates different bug

2019-04-15 Thread Claude Paroz
Please create a new ticket (where you can reference the original one). If you can provide a failing test case, it would be great. Claude Le lundi 15 avril 2019 13:40:53 UTC+2, Melvyn Sopacua | 3YOURMIND a écrit : > Hi, > > I've added a comment on the commit: > https://github.com/django/django/c

Re: Bugfix on #29103 creates different bug

2019-04-15 Thread Melvyn Sopacua | 3YOURMIND
Well, the testcase is a bit hard. I can reproduce it by calling `sqlmigrate` on any migration that adds a char or text field with a default value. The migration it self will go through, but sqlmigrate will fail. I'll look into testcasing that. On Mon, Apr 15, 2019 at 3:25 PM Claude Paroz wrote:

Re: Bugfix on #29103 creates different bug

2019-04-15 Thread Claude Paroz
For the record, the ticket is https://code.djangoproject.com/ticket/30371. The discussion continues there. Claude Le lundi 15 avril 2019 16:56:46 UTC+2, Melvyn Sopacua | 3YOURMIND a écrit : > > Well, the testcase is a bit hard. I can reproduce it by calling > `sqlmigrate` on any migration that