Re: Call for review: #689 - REMOTE_USER authentication

2009-03-14 Thread Gary Wilson Jr.
On Fri, Mar 13, 2009 at 9:48 PM, Malcolm Tredinnick wrote: > I'd go for something shorter: > >        Performs any cleaning on the "username" prior to using it to >        create the user object. Returns the cleaned username. > >        By default, returns the username unchanged. > > I've also ad

Re: Call for review: #689 - REMOTE_USER authentication

2009-03-13 Thread Malcolm Tredinnick
On Thu, 2009-03-12 at 17:50 +1100, Malcolm Tredinnick wrote: > Hey Gary, > > On Thu, 2009-03-12 at 01:40 -0500, Gary Wilson Jr. wrote: > > Just posted an updated patch: > > > > http://code.djangoproject.com/attachment/ticket/689/689.4.diff > > If nobody gets to it beforehand, I'll give this a s

Re: Call for review: #689 - REMOTE_USER authentication

2009-03-12 Thread Jacob Kaplan-Moss
Hey Gary -- Looks good to me. My only comment would be that I'd move the docs into howto/ instead of topics/. Other than that, I'm happy with this code as is. Malcolm's pickier than I am, though, so you might want to see what he's got to say :P Jacob --~--~-~--~~~---

Re: Call for review: #689 - REMOTE_USER authentication

2009-03-11 Thread Malcolm Tredinnick
Hey Gary, On Thu, 2009-03-12 at 01:40 -0500, Gary Wilson Jr. wrote: > Just posted an updated patch: > > http://code.djangoproject.com/attachment/ticket/689/689.4.diff If nobody gets to it beforehand, I'll give this a serious look tomorrow. Cheers, Malcolm --~--~-~--~~

Call for review: #689 - REMOTE_USER authentication

2009-03-11 Thread Gary Wilson Jr.
Just posted an updated patch: http://code.djangoproject.com/attachment/ticket/689/689.4.diff Gary --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to djan