Re: Custom FilterSpecs

2010-11-15 Thread Russell Keith-Magee
On Tue, Nov 16, 2010 at 1:47 PM, Simon Litchfield wrote: > Honza's #5833 is nifty. It's a pity it missed the cut last year for > 1.1. It's been kicking around for 3 years, and there seems to be > plenty of similar tickets that it'd address too. > > Any chance for 1.3? Is it just the lack of tests/

Custom FilterSpecs

2010-11-15 Thread Simon Litchfield
Honza's #5833 is nifty. It's a pity it missed the cut last year for 1.1. It's been kicking around for 3 years, and there seems to be plenty of similar tickets that it'd address too. Any chance for 1.3? Is it just the lack of tests/docs or are there design concerns? -- You received this message b

On [Django] #5833: Custom FilterSpecs

2009-08-03 Thread Yuri Baburov
Hi devs, What do you think, is it a good idea to integrate django-filter by Alex Gaynor into django admin instead of [Django] #5833: Custom FilterSpecs which have now 15 people in cc: already? App is looking nice, and working pretty fine as a foreign library, but using it from

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-16 Thread Ben Gerdemann
lterspec without having to consume the parameters it's using and we could eliminate the strange forwarding to ?e=1 behavior while still having a test that the admin doesn't cause on exception on a bad parameter. Well, I've probably spent more time writing about this small problem tha

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-16 Thread André Eriksson
On Feb 10, 5:43 am, Malcolm Tredinnick wrote: > Ignoring portions of a URL sounds pretty broken. Our goal isn't to be > like other frameworks. It's to behave correctly, in accordance with best > practices for things like URL construction and consumption. I would be a > little unhappy with 'ignori

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-09 Thread Malcolm Tredinnick
On Sun, 2009-02-08 at 10:23 -0800, Ben Gerdemann wrote: > This seems kind of > ugly, but I'll bet there are many frameworks out there that simply > ignore unknown parameters. Thoughts? Ignoring portions of a URL sounds pretty broken. Our goal isn't to be like other frameworks. It's to behave cor

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-08 Thread Ben Gerdemann
On Feb 8, 2:15 pm, Karen Tracey wrote: > I don't have time to devote to this right now, but I'd suggest taking a look > at the svn history of  the tests that check for the ?e=1 redirect.  I have a > vague recollection that it/they may be there as a result of a problem where > incorrect lookup par

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-08 Thread Karen Tracey
On Sun, Feb 8, 2009 at 10:28 AM, Ben Gerdemann wrote: > > On Feb 7, 12:35 pm, Alex Gaynor wrote: > > On Sat, Feb 7, 2009 at 8:27 AM, Ben Gerdemann wrote: > > > > A couple things, first the patch still has a pair of TODO comments, so > > either those comments are no longer applicable, or what th

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-08 Thread Ben Gerdemann
On Feb 7, 12:35 pm, Alex Gaynor wrote: > On Sat, Feb 7, 2009 at 8:27 AM, Ben Gerdemann wrote: > > A couple things, first the patch still has a pair of TODO comments, so > either those comments are no longer applicable, or what they refer to should > be fixed.  Secondly, it needs docs and tests.

Re: Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-07 Thread Alex Gaynor
On Sat, Feb 7, 2009 at 8:27 AM, Ben Gerdemann wrote: > > Hello, > > I'd like to ask what the status of ticked #5833 > http://code.djangoproject.com/ticket/5833 > is. I see that it's listed as a "maybe" feature for 1.1. The patch is > marked "needs improvement," but it's not clear to me from the b

Custom FilterSpecs #5833 planned for Django 1.1?

2009-02-07 Thread Ben Gerdemann
Hello, I'd like to ask what the status of ticked #5833 http://code.djangoproject.com/ticket/5833 is. I see that it's listed as a "maybe" feature for 1.1. The patch is marked "needs improvement," but it's not clear to me from the bug discussion what improvement is being requested. I (gerdemb) hav