Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

You could ask a friend or colleague to review the patch using the patch review checklist [1] and mark it "Ready for checkin" if it looks good. Otherwise, you just wait for someone to review it. [1] https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#pat

Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

Is there something I can do to move this forward? Den torsdag 11 februari 2016 kl. 09:56:15 UTC+1 skrev Tore Lundqvist: > > Thanks for all the help with the patch! I hope its close to being > acceptable now. Can someone have a look at the PR? > > Den tisdag 2 februari 2016 kl. 13:08:51 UTC+1 skr

Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

Thanks for all the help with the patch! I hope its close to being acceptable now. Can someone have a look at the PR? Den tisdag 2 februari 2016 kl. 13:08:51 UTC+1 skrev Tore Lundqvist: > > Ok, got that sorted now. How about the fix, is it reasonable? > > > Den tisdag 2 februari 2016 kl. 11:51:19

Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

Ok, got that sorted now. How about the fix, is it reasonable? Den tisdag 2 februari 2016 kl. 11:51:19 UTC+1 skrev is_null: > > Just click "Details" and then "Console output". You'll find this: > > + flake8 > ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid > syntax >

Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

Just click "Details" and then "Console output". You'll find this: + flake8 ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid syntax ERROR: /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py Imports are incorrectly sorted. --- /home/jenkins/workspace/isort

Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)

Thanks for the feedback! I have updated the PR, can someone have a look at it again? I noticed that there where failing checks (flake8, isort) but it does not say why that it, do I need to fix something? Cheers Tore Lundqvist Den fredag 29 januari 2016 kl. 15:20:11 UTC+1 skrev Tore Lundqvist:

Logged out sessions are resurrected by concurrent requests (ticket 21608)

Hi, everyone! I confirmed this (21608) non critical security bug a while ago and have sense then made a unit test and a fix for it. I have not gotten any feedback on my PR yet, is there something more I need to do to have someone look at this? Best Regards Tore Lundqvist -- You received this