Re: Organizing the built-in system check framework's hint messages

2016-05-20 Thread Michal Petrucha
On Thu, May 19, 2016 at 02:56:48PM -0700, Quentin Fulsher wrote: > Here is a super quick proof of concept that I put together. I just branched > my fork of django and added a little to it. Here is the comparing changes > page[1]. > > Quick summary of changes: I created a dictionary that would co

Re: Organizing the built-in system check framework's hint messages

2016-05-19 Thread Quentin Fulsher
Here is a super quick proof of concept that I put together. I just branched my fork of django and added a little to it. Here is the comparing changes page[1]. Quick summary of changes: I created a dictionary that would contain the (id: message) pairs. I also modified the CheckMessage.__init__ m

Re: Organizing the built-in system check framework's hint messages

2016-05-19 Thread Tim Graham
The security checks errors are defined as module level constants to avoid some redundancy since these can be imported in tests: https://github.com/django/django/blob/0eac5535f7afd2295b1db978dffb97d79030807e/django/core/checks/security/base.py. If you feel your approach would be an improvement, m

Organizing the built-in system check framework's hint messages

2016-05-18 Thread Quentin Fulsher
Hi all, Recently I was trying to fix a bug that required me to alter the hint message of the `fields.E306`[1] system check error[2]. The bug in question added a condition to a check which if failed caused the instantiation of a `django.core.checks.Error` object. In order to change the `Error`'