Re: SchemaEditor + DatabaseConnection

2014-08-01 Thread Andrew Godwin
At the moment you'll need to make sure both Creation and SchemaEditor do the right thing for stuff like that. We bumped "deprecate DatabaseCreation" back to 2.0 for a final removal as it was so complex and so much stuff relies on it (including SchemaEditor in places where I didn't want to duplicate

Re: SchemaEditor + DatabaseConnection

2014-07-27 Thread Tim Graham
FWIW, I may have closed that PR prematurely. I didn't realize SchemaEditor still relied on DatabaseCreation and I'm not sure what the final combination of the two will ultimately look like. On Sunday, July 27, 2014 7:38:08 AM UTC-4, Christopher D'Cunha wrote: > > Hi All, > > I'm working on https

SchemaEditor + DatabaseConnection

2014-07-27 Thread Christopher D'Cunha
Hi All, I'm working on https://code.djangoproject.com/ticket/56 for the EuroPython sprint. There was a PR for it (https://github.com/django/django/pull/1156) but it was rejected by Tim Graham because the code should apparently be in the SchemaEditor instead of the DatabaseCreation class. As I