Sites Framework: RequestSite and get_current

2010-09-30 Thread Gabriel Hurley
I went to triage a few tickets tonight, and noticed that #8960, #10235, #10608 and #13814 have all arrived at essentially the same conclusion: there needs to be a single idiomatic way to get either the current Site object if contrib.sites is installed, or a RequestSite object if not. All four ticke

Re: Sites Framework: RequestSite and get_current

2010-10-01 Thread Gabriel Hurley
I should add that #10909 is another ticket that ultimately revolves around getting a Site/RequestSite object to have access to the current domain. Easily fixed once this function/method exists. While I'm at it, #10944 would be moved one step closer by having a consistent way to get the current Sit

Re: Sites Framework: RequestSite and get_current

2010-10-01 Thread burc...@gmail.com
Hi Gabriel, everyone, I'd also like if such function can support option "developer provides function that knows the current site based on the request". That means, "get my site" function ultimately needs a backend connector! I think this might be fixed in the way we did with urlconf: http://docs.

Re: Sites Framework: RequestSite and get_current

2010-10-01 Thread Luke Plant
On Thu, 2010-09-30 at 23:48 -0700, Gabriel Hurley wrote: > I went to triage a few tickets tonight, and noticed that #8960, > #10235, #10608 and #13814 have all arrived at essentially the same > conclusion: there needs to be a single idiomatic way to get either the > current Site object if contrib.s

Re: Sites Framework: RequestSite and get_current

2010-10-01 Thread Gabriel Hurley
I can see why you might want control at the middleware level, but I'm not sure that's the only/best way to accomplish that goal, and it seems like the subject of a totally separate ticket to me. I'd rather see this set of redundant problems solved in a simple fashion rather than get into a debate o

Re: Sites Framework: RequestSite and get_current

2010-10-01 Thread Luke Plant
On Fri, 2010-10-01 at 12:08 -0700, Gabriel Hurley wrote: > I can see why you might want control at the middleware level, but I'm > not sure that's the only/best way to accomplish that goal, and it > seems like the subject of a totally separate ticket to me. I'd rather > see this set of redundant pr

Re: Sites Framework: RequestSite and get_current

2010-10-04 Thread Gabriel Hurley
There is now a ticket and a patch for this, which includes the utility method and a rollup of fixes for the aforementioned tickets as appropriate. Tests and docs included. Details are in the ticket description: http://code.djangoproject.com/ticket/14386 I'd love to get some feedback on it when po

Re: Sites Framework: RequestSite and get_current

2010-10-04 Thread burc...@gmail.com
Hi Gabriel, looking good! On Mon, Oct 4, 2010 at 2:59 PM, Gabriel Hurley wrote: > There is now a ticket and a patch for this, which includes the utility > method and a rollup of fixes for the aforementioned tickets as > appropriate. Tests and docs included. Details are in the ticket > descriptio