Re: What can I do to get feedback on my pull request?

2013-03-26 Thread Jacob Kaplan-Moss
Adrian's one of the BDFLs (I'm the other), so if he says "no" that stands. Usually, we operate the way most open source projects do: "rough consensus and working code". You've got the second ("working code") so you need to work on the first, I think. Usually a strong consensus is enough to overrid

Re: What can I do to get feedback on my pull request?

2013-03-26 Thread meric
Is the 'vote' a majority or a consensus must be achieved? -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. T

Re: What can I do to get feedback on my pull request?

2013-03-26 Thread Jacob Kaplan-Moss
On Mon, Mar 25, 2013 at 10:50 PM, meric wrote: > What action, if any, do you suggest I take now? If it's gonna get in, you/we need to talk Adrian into dropping his -1 vote. Jacob -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubsc

Re: What can I do to get feedback on my pull request?

2013-03-25 Thread meric
What action, if any, do you suggest I take now? On Tuesday, March 26, 2013 2:42:11 PM UTC+11, Ramiro Morales wrote: > > On Tue, Mar 26, 2013 at 12:36 AM, meric > > wrote: > > Thanks, I'll reply to that thread. I posted my proposal 6 months before > that > > post, would've been nice if they pos

Re: What can I do to get feedback on my pull request?

2013-03-25 Thread Ramiro Morales
On Tue, Mar 26, 2013 at 12:36 AM, meric wrote: > Thanks, I'll reply to that thread. I posted my proposal 6 months before that > post, would've been nice if they posted in my thread... Jacob voted in favor of the feature (on the #16774 [1]ticket) and Adrian voted -1 on that thread. But they were

Re: What can I do to get feedback on my pull request?

2013-03-25 Thread meric
Thanks, I'll reply to that thread. I posted my proposal 6 months before that post, would've been nice if they posted in my thread... On Tuesday, March 26, 2013 2:33:14 PM UTC+11, Ramiro Morales wrote: > > On Tue, Mar 26, 2013 at 12:28 AM, meric > > wrote: > > I have made a pull request for djan

Re: What can I do to get feedback on my pull request?

2013-03-25 Thread Ramiro Morales
On Tue, Mar 26, 2013 at 12:28 AM, meric wrote: > I have made a pull request for django 6 months ago, but it doesn't seem to > be getting much response so far. > > What can I do to get more feedback as to what's wrong with it, and try to > get it accepted? > > Here is the pull request: > > https://

What can I do to get feedback on my pull request?

2013-03-25 Thread meric
I have made a pull request for django 6 months ago, but it doesn't seem to be getting much response so far. What can I do to get more feedback as to what's wrong with it, and try to get it accepted? Here is the pull request: https://github.com/django/django/pull/378 -- You received this mess