Re: django-firebird backend: migrations and NULL fields

2014-06-19 Thread Andrew Godwin
Thanks Tim. I sometimes just forget to run the backport script... Andrew On Thu, Jun 19, 2014 at 8:04 AM, Tim Graham wrote: > Backported in 30d8b95139a1fa3070f3b112115e624ffcf8e555, thanks for the > reminder. > > > On Thursday, June 19, 2014 9:36:54 AM UTC-4, Maximiliano Robaina wrote: >> >> >

Re: django-firebird backend: migrations and NULL fields

2014-06-19 Thread Tim Graham
Backported in 30d8b95139a1fa3070f3b112115e624ffcf8e555, thanks for the reminder. On Thursday, June 19, 2014 9:36:54 AM UTC-4, Maximiliano Robaina wrote: > > > El martes, 20 de mayo de 2014 09:27:48 UTC-3, Andrew Godwin escribió: >> >> Yes, I'm aware add_field is also in need of expansion points -

Re: django-firebird backend: migrations and NULL fields

2014-06-19 Thread Maximiliano Robaina
El martes, 20 de mayo de 2014 09:27:48 UTC-3, Andrew Godwin escribió: > > Yes, I'm aware add_field is also in need of expansion points - the same > issue was raised with the MSSQL backend too. > > I'm more than happy to add these in now or after 1.7 in a point release; > the actual implementatio

Re: django-firebird backend: migrations and NULL fields

2014-05-20 Thread Andrew Godwin
Yes, I'm aware add_field is also in need of expansion points - the same issue was raised with the MSSQL backend too. I'm more than happy to add these in now or after 1.7 in a point release; the actual implementation of those methods is private so we can change it around a little (or at least, we c

Re: django-firebird backend: migrations and NULL fields

2014-05-16 Thread Maximiliano Robaina
El viernes, 16 de mayo de 2014 09:49:15 UTC-3, Andrew Godwin escribió: > > Let's go with a feature for this then. > > Maxi, did you want to submit a patch, or do you want me to add it at some > point next week! > > Andrew > I'll appreciate if you can add it. BTW, are there other areas that nee

Re: django-firebird backend: migrations and NULL fields

2014-05-16 Thread Andrew Godwin
Let's go with a feature for this then. Maxi, did you want to submit a patch, or do you want me to add it at some point next week! Andrew On Wed, May 14, 2014 at 6:27 PM, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > For what it’s worth, I recently added a feature to add “FROM

Re: django-firebird backend: migrations and NULL fields

2014-05-14 Thread Aymeric Augustin
For what it's worth, I recently added a feature to add "FROM DUAL" where Oracle needs it. This looks roughly similar. Maybe we could use the same approach. (I didn't look closely.) -- Aymeric. On 14 mai 2014, at 17:06, Andrew Godwin wrote: > Hmm, I'm not sure about adding more features, b

Re: django-firebird backend: migrations and NULL fields

2014-05-14 Thread Andrew Godwin
Hmm, I'm not sure about adding more features, but it might be cleaner... Andrew On Wed, May 14, 2014 at 8:00 AM, Jeremy Dunck wrote: > How about adding a flag to Operations? implied_null, perhaps. > On May 14, 2014 7:52 AM, "Andrew Godwin" wrote: > >> Hi, >> >> That's currently the only appro

Re: django-firebird backend: migrations and NULL fields

2014-05-14 Thread Jeremy Dunck
How about adding a flag to Operations? implied_null, perhaps. On May 14, 2014 7:52 AM, "Andrew Godwin" wrote: > Hi, > > That's currently the only approach I'm afraid - there's an open issue > (raised by Shai Berger I believe) that column_sql should be broken down > into more component pieces so i

Re: django-firebird backend: migrations and NULL fields

2014-05-14 Thread Andrew Godwin
Hi, That's currently the only approach I'm afraid - there's an open issue (raised by Shai Berger I believe) that column_sql should be broken down into more component pieces so it can be more easily changed, but that's a difficult task to do and not something I want to go and change completely as w

django-firebird backend: migrations and NULL fields

2014-05-14 Thread maxi
Hi, I'm trying to implement the new schema migration of django 1.7 for django-firebird backend. In column_sql method, when the field can be null, in firebird, is not necessary add the NULL keyword. So to change this behavior I need override the entire column_sql method just to change one line: